On Wed, Jan 09, 2019 at 01:14:14PM -0800, Radhakrishna Sripada wrote:
> intel_dp->dsc_dpcd is defined as an array making the if check redundant.
>

Yes I agree, I guess when I added that if check it was anot an array to begin
with and then forgot to take it off.

Looks good to me.

Reviewed-by: Manasi Navare <manasi.d.nav...@intel.com>

Manasi
 
> Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.srip...@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index 95813e21ae02..908e41f9cb7d 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4958,9 +4958,8 @@ static int i915_dsc_fec_support_show(struct seq_file 
> *m, void *data)
>               crtc_state = to_intel_crtc_state(crtc->state);
>               seq_printf(m, "DSC_Enabled: %s\n",
>                          yesno(crtc_state->dsc_params.compression_enable));
> -             if (intel_dp->dsc_dpcd)
> -                     seq_printf(m, "DSC_Sink_Support: %s\n",
> -                                
> yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
> +             seq_printf(m, "DSC_Sink_Support: %s\n",
> +                        yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
>               if (!intel_dp_is_edp(intel_dp))
>                       seq_printf(m, "FEC_Sink_Support: %s\n",
>                                  
> yesno(drm_dp_sink_supports_fec(intel_dp->fec_capable)));
> -- 
> 2.20.0.rc2.7.g965798d1f299
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to