From: Brian Starkey <brian.star...@arm.com>

Update the connector search to also optionally attempt to find a
non-writeback connector to clone to.

Add a subtest which is the same as writeback-check-output, but also
clones to the second connector.

Signed-off-by: Brian Starkey <brian.star...@arm.com>
[rebased and addressed comments by Maarten]
Signed-off-by: Liviu Dudau <liviu.du...@arm.com>
---
 tests/kms_writeback.c | 64 +++++++++++++++++++++++++++++++++++++++----
 1 file changed, 59 insertions(+), 5 deletions(-)

diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index 0f20dadd2..ae536bbfa 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -51,7 +51,8 @@ static drmModePropertyBlobRes 
*get_writeback_formats_blob(igt_output_t *output)
        return blob;
 }
 
-static bool check_writeback_config(igt_display_t *display, igt_output_t 
*output)
+static bool check_writeback_config(igt_display_t *display, igt_output_t 
*output,
+                                  int pipe, igt_output_t **clone)
 {
        igt_fb_t input_fb, output_fb;
        igt_plane_t *plane;
@@ -91,6 +92,30 @@ static bool check_writeback_config(igt_display_t *display, 
igt_output_t *output)
 
        ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
                                            DRM_MODE_ATOMIC_ALLOW_MODESET, 
NULL);
+       if (!ret && clone) {
+               /* Try and find a clone */
+               int i, newret;
+               *clone = NULL;
+
+               for (i = 0; i < display->n_outputs; i++) {
+                       igt_output_t *second_output = &display->outputs[i];
+                       if (output != second_output &&
+                           igt_pipe_connector_valid(pipe, second_output)) {
+
+                               igt_output_clone_pipe(second_output, pipe);
+                               igt_output_override_mode(output, 
&override_mode);
+                               newret = igt_display_try_commit_atomic(display, 
DRM_MODE_ATOMIC_TEST_ONLY |
+                                                                      
DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+                               igt_output_set_pipe(second_output, PIPE_NONE);
+                               igt_debug("try_commit_atomic clone returned 
%d\n", newret);
+                               if (!newret) {
+                                       *clone = second_output;
+                                       igt_debug("Selected clone %s\n", 
(*clone)->name);
+                                       break;
+                               }
+                       }
+               }
+       }
        igt_plane_set_fb(plane, NULL);
        igt_remove_fb(display->drm_fd, &input_fb);
        igt_remove_fb(display->drm_fd, &output_fb);
@@ -98,7 +123,8 @@ static bool check_writeback_config(igt_display_t *display, 
igt_output_t *output)
        return !ret;
 }
 
-static igt_output_t *kms_writeback_get_output(igt_display_t *display)
+static igt_output_t *kms_writeback_get_output(igt_display_t *display, enum 
pipe *pipe,
+                                             igt_output_t **clone)
 {
        int i;
 
@@ -114,10 +140,16 @@ static igt_output_t 
*kms_writeback_get_output(igt_display_t *display)
                for (j = 0; j < igt_display_get_n_pipes(display); j++) {
                        igt_output_set_pipe(output, j);
 
-                       if (check_writeback_config(display, output)) {
+                       if (check_writeback_config(display, output, j, clone)) {
                                igt_debug("Using connector %u:%s on pipe %d\n",
                                          
output->config.connector->connector_id,
                                          output->name, j);
+                               if (clone && *clone)
+                                       igt_debug("Cloning to connector 
%u:%s\n",
+                                                 
(*clone)->config.connector->connector_id,
+                                                 (*clone)->name);
+                               if (pipe)
+                                       *pipe = j;
                                return output;
                        }
                }
@@ -335,10 +367,11 @@ static void writeback_check_output(igt_output_t *output, 
igt_plane_t *plane,
 igt_main
 {
        igt_display_t display;
-       igt_output_t *output;
+       igt_output_t *output, *clone;
        igt_plane_t *plane;
        igt_fb_t input_fb;
        drmModeModeInfo mode;
+       enum pipe pipe;
        int ret;
 
        memset(&display, 0, sizeof(display));
@@ -353,7 +386,7 @@ igt_main
 
                igt_require(display.is_atomic);
 
-               output = kms_writeback_get_output(&display);
+               output = kms_writeback_get_output(&display, &pipe, &clone);
                igt_require(output);
 
                if (output->use_override_mode)
@@ -431,6 +464,27 @@ igt_main
                igt_remove_fb(display.drm_fd, &output_fb);
        }
 
+       igt_subtest("writeback-check-output-clone") {
+               igt_fb_t output_fb;
+
+               igt_require(clone);
+
+               ret = igt_create_fb(display.drm_fd, mode.hdisplay, 
mode.vdisplay,
+                                   DRM_FORMAT_XRGB8888,
+                                   igt_fb_mod_to_tiling(0),
+                                   &output_fb);
+               igt_require(ret > 0);
+
+               igt_output_clone_pipe(clone, pipe);
+               igt_output_override_mode(clone, &mode);
+
+               writeback_check_output(output, plane, &input_fb, &output_fb);
+
+               igt_output_set_pipe(clone, PIPE_NONE);
+
+               igt_remove_fb(display.drm_fd, &output_fb);
+       }
+
        igt_fixture {
                igt_remove_fb(display.drm_fd, &input_fb);
                igt_display_fini(&display);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to