== Series Details ==
Series: series starting with [01/46] drm/i915: Hack and slash, throttle
execbuffer hogs (rev2)
URL : https://patchwork.freedesktop.org/series/56281/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d557d3a829de drm/i915: Hack and slash, throttle execbuffer hogs
b4820cad7002 drm/i915: Revoke mmaps and prevent access to fence registers
across reset
a5676a243ca9 drm/i915: Force the GPU reset upon wedging
0ebb8e590ea9 drm/i915: Uninterruptibly drain the timelines on unwedging
d12c0a13c719 drm/i915: Wait for old resets before applying debugfs/i915_wedged
52ba77ed3d1d drm/i915: Serialise resets with wedging
b3e799f976f3 drm/i915: Don't claim an unstarted request was guilty
eb622f2f3ea8 drm/i915/execlists: Suppress mere WAIT preemption
72bd8142da29 drm/i915/execlists: Suppress redundant preemption
21b926286743 drm/i915: Make request allocation caches global
-:162: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#162:
new file mode 100644
-:167: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#167: FILE: drivers/gpu/drm/i915/i915_globals.c:1:
+/*
-:278: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#278: FILE: drivers/gpu/drm/i915/i915_globals.h:1:
+/*
-:619: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible
side-effects?
#619: FILE: drivers/gpu/drm/i915/i915_scheduler.h:95:
+#define priolist_for_each_request(it, plist, idx) \
+ for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+ list_for_each_entry(it, &(plist)->requests[idx], sched.link)
-:619: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible
side-effects?
#619: FILE: drivers/gpu/drm/i915/i915_scheduler.h:95:
+#define priolist_for_each_request(it, plist, idx) \
+ for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+ list_for_each_entry(it, &(plist)->requests[idx], sched.link)
-:623: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible
side-effects?
#623: FILE: drivers/gpu/drm/i915/i915_scheduler.h:99:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+ for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+ list_for_each_entry_safe(it, n, \
+ &(plist)->requests[idx - 1], \
+ sched.link)
-:623: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible
side-effects?
#623: FILE: drivers/gpu/drm/i915/i915_scheduler.h:99:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+ for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+ list_for_each_entry_safe(it, n, \
+ &(plist)->requests[idx - 1], \
+ sched.link)
total: 0 errors, 3 warnings, 4 checks, 803 lines checked
080b49acfcea drm/i915: Keep timeline HWSP allocated until idle across the system
919f7b05e698 drm/i915/execlists: Refactor out can_merge_rq()
26f6a47bdaba drm/i915: Compute the global scheduler caps
217daeef0475 drm/i915: Use HW semaphores for inter-engine synchronisation on
gen8+
-:333: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#333: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:109:
+#define MI_SEMAPHORE_SAD_GT_SDD (0<<12)
^
-:335: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#335: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:111:
+#define MI_SEMAPHORE_SAD_LT_SDD (2<<12)
^
-:336: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#336: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:112:
+#define MI_SEMAPHORE_SAD_LTE_SDD (3<<12)
^
-:337: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#337: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:113:
+#define MI_SEMAPHORE_SAD_EQ_SDD (4<<12)
^
-:338: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#338: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:114:
+#define MI_SEMAPHORE_SAD_NEQ_SDD (5<<12)
^
total: 0 errors, 0 warnings, 5 checks, 298 lines checked
13a17cc9d0e8 drm/i915: Prioritise non-busywait semaphore workloads
1efc4bfb4abc drm/i915: Show support for accurate sw PMU busyness tracking
9d9bf5e37162 drm/i915: Apply rps waitboosting for dma_fence_wait_timeout()
ca1dd369a8fa drm/i915: Replace global_seqno with a hangcheck heartbeat seqno
ef1b7ea6c12a drm/i915/pmu: Always sample an active ringbuffer
77aea933c6b5 drm/i915: Remove access to global seqno in the HWSP
8f175c3d19cb drm/i915: Remove i915_request.global_seqno
9a0deb68148b drm/i915: Force GPU idle on suspend
ed75f37144ba drm/i915/selftests: Improve switch-to-kernel-context checking
905940663467 drm/i915: Do a synchronous switch-to-kernel-context on idling
2aae0d45d5e1 drm/i915: Store the BIT(engine->id) as the engine's mask
366712549703 drm/i915: Refactor common code to load initial power context
9472b88e9510 drm/i915: Reduce presumption of request ordering for barriers
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:265: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 1 warnings, 0 checks, 203 lines checked
f0e040b2b916 drm/i915: Remove has-kernel-context
438122eecc4a drm/i915: Introduce the i915_user_extension_method
-:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#58:
new file mode 100644
-:63: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#63: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1:
+/*
-:112: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#112: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1:
+/*
-:140: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible
side-effects?
#140: FILE: drivers/gpu/drm/i915/i915_utils.h:108:
+#define container_of_user(ptr, type, member) ({
\
+ void __user *__mptr = (void __user *)(ptr); \
+ BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
+ !__same_type(*(ptr), void), \
+ "pointer type mismatch in container_of()"); \
+ ((type __user *)(__mptr - offsetof(type, member))); })
-:140: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible
side-effects?
#140: FILE: drivers/gpu/drm/i915/i915_utils.h:108:
+#define container_of_user(ptr, type, member) ({
\
+ void __user *__mptr = (void __user *)(ptr); \
+ BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
+ !__same_type(*(ptr), void), \
+ "pointer type mismatch in container_of()"); \
+ ((type __user *)(__mptr - offsetof(type, member))); })
-:140: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as
'(member)' to avoid precedence issues
#140: FILE: drivers/gpu/drm/i915/i915_utils.h:108:
+#define container_of_user(ptr, type, member) ({
\
+ void __user *__mptr = (void __user *)(ptr); \
+ BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
+ !__same_type(*(ptr), void), \
+ "pointer type mismatch in container_of()"); \
+ ((type __user *)(__mptr - offsetof(type, member))); })
total: 0 errors, 3 warnings, 3 checks, 109 lines checked
28c66fc3a304 drm/i915: Track active engines within a context
3bc89baea5ad drm/i915: Introduce a context barrier callback
1e28b2eb9aed drm/i915: Create/destroy VM (ppGTT) for use with contexts
-:37: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#37: FILE: drivers/gpu/drm/i915/i915_drv.h:220:
+ struct mutex vm_lock;
-:551: WARNING:LINE_SPACING: Missing a blank line after declarations
#551: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:503:
+ struct drm_file *file;
+ IGT_TIMEOUT(end_time);
-:627: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#627: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:565:
+ ncontexts = dw = 0;
-:678: WARNING:LINE_SPACING: Missing a blank line after declarations
#678: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:610:
+ struct drm_file *file;
+ IGT_TIMEOUT(end_time);
-:758: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#758: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:686:
+ ncontexts = dw = 0;
-:876: WARNING:LONG_LINE: line over 100 characters
#876: FILE: include/uapi/drm/i915_drm.h:402:
+#define DRM_IOCTL_I915_GEM_VM_CREATE DRM_IOWR(DRM_COMMAND_BASE +
DRM_I915_GEM_VM_CREATE, struct drm_i915_gem_vm_control)
-:877: WARNING:LONG_LINE: line over 100 characters
#877: FILE: include/uapi/drm/i915_drm.h:403:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE +
DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
-:877: WARNING:SPACING: space prohibited between function name and open
parenthesis '('
#877: FILE: include/uapi/drm/i915_drm.h:403:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE +
DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
-:877: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#877: FILE: include/uapi/drm/i915_drm.h:403:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE +
DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
total: 1 errors, 5 warnings, 3 checks, 832 lines checked
b464aad73304 drm/i915: Extend CONTEXT_CREATE to set parameters upon construction
-:26: WARNING:LONG_LINE: line over 100 characters
#26: FILE: drivers/gpu/drm/i915/i915_drv.c:2997:
+ DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_CREATE_EXT,
i915_gem_context_create_ioctl, DRM_RENDER_ALLOW),
-:522: WARNING:LONG_LINE: line over 100 characters
#522: FILE: include/uapi/drm/i915_drm.h:392:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE +
DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)
-:522: WARNING:SPACING: space prohibited between function name and open
parenthesis '('
#522: FILE: include/uapi/drm/i915_drm.h:392:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE +
DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)
-:522: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#522: FILE: include/uapi/drm/i915_drm.h:392:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE +
DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)
total: 1 errors, 3 warnings, 0 checks, 666 lines checked
7e0736603235 drm/i915: Allow contexts to share a single timeline across all
engines
4a8db894f67f drm/i915: Fix I915_EXEC_RING_MASK
3b615f9cb0b6 drm/i915: Remove last traces of exec-id (GEM_BUSY)
cb4fc91f67fa drm/i915: Re-arrange execbuf so context is known before engine
3adceade6ab7 drm/i915: Allow a context to define its set of engines
5a1b17ecbcbd drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local
ctx->engine[]
8ac639a97b91 drm/i915: Pass around the intel_context
d56d1a629f1f drm/i915: Split struct intel_context definition to its own header
-:291: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#291:
new file mode 100644
-:296: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#296: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:1:
+/*
-:557: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#557: FILE: drivers/gpu/drm/i915/i915_timeline_types.h:1:
+/*
-:581: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#581: FILE: drivers/gpu/drm/i915/i915_timeline_types.h:25:
+ spinlock_t lock;
-:642: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#642: FILE: drivers/gpu/drm/i915/intel_context.h:1:
+/*
-:695: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#695: FILE: drivers/gpu/drm/i915/intel_context_types.h:1:
+/*
-:761: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#761: FILE: drivers/gpu/drm/i915/intel_engine_types.h:1:
+/*
-:1048: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#1048: FILE: drivers/gpu/drm/i915/intel_engine_types.h:288:
+ spinlock_t irq_lock;
-:1264: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible
side-effects?
#1264: FILE: drivers/gpu/drm/i915/intel_engine_types.h:504:
+#define instdone_slice_mask(dev_priv__) \
+ (IS_GEN(dev_priv__, 7) ? \
+ 1 : RUNTIME_INFO(dev_priv__)->sseu.slice_mask)
-:1268: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible
side-effects?
#1268: FILE: drivers/gpu/drm/i915/intel_engine_types.h:508:
+#define instdone_subslice_mask(dev_priv__) \
+ (IS_GEN(dev_priv__, 7) ? \
+ 1 : RUNTIME_INFO(dev_priv__)->sseu.subslice_mask[0])
-:1272: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible
side-effects?
#1272: FILE: drivers/gpu/drm/i915/intel_engine_types.h:512:
+#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \
+ for ((slice__) = 0, (subslice__) = 0; \
+ (slice__) < I915_MAX_SLICES; \
+ (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ?
(subslice__) + 1 : 0, \
+ (slice__) += ((subslice__) == 0)) \
+ for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) &&
\
+ (BIT(subslice__) &
instdone_subslice_mask(dev_priv__)))
-:1272: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'slice__' - possible
side-effects?
#1272: FILE: drivers/gpu/drm/i915/intel_engine_types.h:512:
+#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \
+ for ((slice__) = 0, (subslice__) = 0; \
+ (slice__) < I915_MAX_SLICES; \
+ (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ?
(subslice__) + 1 : 0, \
+ (slice__) += ((subslice__) == 0)) \
+ for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) &&
\
+ (BIT(subslice__) &
instdone_subslice_mask(dev_priv__)))
-:1272: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice__' - possible
side-effects?
#1272: FILE: drivers/gpu/drm/i915/intel_engine_types.h:512:
+#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \
+ for ((slice__) = 0, (subslice__) = 0; \
+ (slice__) < I915_MAX_SLICES; \
+ (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ?
(subslice__) + 1 : 0, \
+ (slice__) += ((subslice__) == 0)) \
+ for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) &&
\
+ (BIT(subslice__) &
instdone_subslice_mask(dev_priv__)))
-:1853: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#1853: FILE: drivers/gpu/drm/i915/intel_workarounds_types.h:1:
+/*
total: 0 errors, 7 warnings, 7 checks, 1796 lines checked
6fe3b4c65bbf drm/i915: Move over to intel_context_lookup()
-:245: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#245: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:140:
+ spinlock_t hw_contexts_lock;
-:283: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#283:
new file mode 100644
-:288: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#288: FILE: drivers/gpu/drm/i915/intel_context.c:1:
+/*
total: 0 errors, 2 warnings, 1 checks, 615 lines checked
520f60c930cd drm/i915: Load balancing across a virtual engine
-:825: WARNING:LINE_SPACING: Missing a blank line after declarations
#825: FILE: drivers/gpu/drm/i915/intel_lrc.c:3359:
+ struct intel_engine_cs *actual = ve->siblings[0];
+ virtual_engine_free(&ve->kref);
total: 0 errors, 1 warnings, 0 checks, 1016 lines checked
96abf66cf3a3 drm/i915: Extend execution fence to support a callback
501ddeed6a11 drm/i915/execlists: Virtual engine bonding
953cd4c6741f drm/i915: Allow specification of parallel execbuf
-:132: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#132: FILE: include/uapi/drm/i915_drm.h:1125:
+#define I915_EXEC_FENCE_SUBMIT (1<<20)
^
-:134: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#134: FILE: include/uapi/drm/i915_drm.h:1127:
+#define __I915_EXEC_UNKNOWN_FLAGS (-(I915_EXEC_FENCE_SUBMIT<<1))
^
total: 0 errors, 0 warnings, 2 checks, 90 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
