== Series Details ==

Series: Refactor to expand subslice mask (rev4)
URL   : https://patchwork.freedesktop.org/series/59742/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0cad53dc6dba drm/i915: Use local variable for SSEU info in GETPARAM ioctl
da46929baac9 drm/i915: Add macro for SSEU stride calculation
723f76e4f3b1 drm/i915: Move calculation of subslices per slice to new function
4302585e7be1 drm/i915: Move sseu helper functions to intel_sseu.h
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:50: CHECK:SPACING: No space is necessary after a cast
#50: FILE: drivers/gpu/drm/i915/gt/intel_sseu.h:100:
+               eu_mask |= ((u16) sseu->eu_mask[offset + i]) <<

total: 0 errors, 1 warnings, 1 checks, 112 lines checked
ca2160abb603 drm/i915: Expand subslice mask
-:82: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sseu__' - possible 
side-effects?
#82: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:542:
+#define instdone_has_subslice(dev_priv__, sseu__, slice__, subslice__) \
+       ((IS_GEN(dev_priv__, 7) ? \
+         1 : (sseu__)->subslice_mask[slice__ * (sseu__)->ss_stride + \
+                                     subslice__ / BITS_PER_BYTE]) & \
+        BIT(subslice__ % BITS_PER_BYTE)) \
+

-:82: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'slice__' may be better as 
'(slice__)' to avoid precedence issues
#82: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:542:
+#define instdone_has_subslice(dev_priv__, sseu__, slice__, subslice__) \
+       ((IS_GEN(dev_priv__, 7) ? \
+         1 : (sseu__)->subslice_mask[slice__ * (sseu__)->ss_stride + \
+                                     subslice__ / BITS_PER_BYTE]) & \
+        BIT(subslice__ % BITS_PER_BYTE)) \
+

-:82: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice__' - possible 
side-effects?
#82: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:542:
+#define instdone_has_subslice(dev_priv__, sseu__, slice__, subslice__) \
+       ((IS_GEN(dev_priv__, 7) ? \
+         1 : (sseu__)->subslice_mask[slice__ * (sseu__)->ss_stride + \
+                                     subslice__ / BITS_PER_BYTE]) & \
+        BIT(subslice__ % BITS_PER_BYTE)) \
+

-:82: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'subslice__' may be better as 
'(subslice__)' to avoid precedence issues
#82: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:542:
+#define instdone_has_subslice(dev_priv__, sseu__, slice__, subslice__) \
+       ((IS_GEN(dev_priv__, 7) ? \
+         1 : (sseu__)->subslice_mask[slice__ * (sseu__)->ss_stride + \
+                                     subslice__ / BITS_PER_BYTE]) & \
+        BIT(subslice__ % BITS_PER_BYTE)) \
+

-:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv_' - possible 
side-effects?
#88: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:548:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+       for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+            (subslice_) = ((subslice_) + 1) < I915_MAX_SUBSLICES ? (subslice_) 
+ 1 : 0, \
+              (slice_) += ((subslice_) == 0)) \
+               for_each_if(instdone_has_slice(dev_priv_, sseu_, slice) && \
+                           instdone_has_subslice(dev_priv_, sseu_, slice_, 
subslice_)) \
 

-:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sseu_' - possible 
side-effects?
#88: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:548:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+       for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+            (subslice_) = ((subslice_) + 1) < I915_MAX_SUBSLICES ? (subslice_) 
+ 1 : 0, \
+              (slice_) += ((subslice_) == 0)) \
+               for_each_if(instdone_has_slice(dev_priv_, sseu_, slice) && \
+                           instdone_has_subslice(dev_priv_, sseu_, slice_, 
subslice_)) \
 

-:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'slice_' - possible 
side-effects?
#88: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:548:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+       for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+            (subslice_) = ((subslice_) + 1) < I915_MAX_SUBSLICES ? (subslice_) 
+ 1 : 0, \
+              (slice_) += ((subslice_) == 0)) \
+               for_each_if(instdone_has_slice(dev_priv_, sseu_, slice) && \
+                           instdone_has_subslice(dev_priv_, sseu_, slice_, 
subslice_)) \
 

-:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice_' - possible 
side-effects?
#88: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:548:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+       for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+            (subslice_) = ((subslice_) + 1) < I915_MAX_SUBSLICES ? (subslice_) 
+ 1 : 0, \
+              (slice_) += ((subslice_) == 0)) \
+               for_each_if(instdone_has_slice(dev_priv_, sseu_, slice) && \
+                           instdone_has_subslice(dev_priv_, sseu_, slice_, 
subslice_)) \
 

total: 0 errors, 0 warnings, 8 checks, 632 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to