On Tue, Jun 18, 2019 at 10:26:52AM +0300, Laurent Pinchart wrote:
> Hi Sean,
>
> Thank you for the patch.
>
> On Mon, Jun 17, 2019 at 02:15:42PM -0400, Sean Paul wrote:
> > From: Sean Paul <seanp...@chromium.org>
> >
> > drm_atomic_get_crtc_state() returns an error pointer when it fails, so
> > the null check is doing nothing here.
> >
> > Credit to 0-day/Dan Carpenter for reporting this.
> >
> > Fixes: 6f3b62781bbd ("drm: Convert connector_helper_funcs->atomic_check to
> > accept drm_atomic_state")
> > Cc: Daniel Vetter <dan...@ffwll.ch>
> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
> > Cc: Jani Nikula <jani.nik...@linux.intel.com>
> > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
> > Cc: Ben Skeggs <bske...@redhat.com>
> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> > Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> > Cc: Eric Anholt <e...@anholt.net>
> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> [for rcar lvds]
> > Cc: Sean Paul <seanp...@chromium.org>
> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
> > Cc: Maxime Ripard <maxime.rip...@bootlin.com>
> > Cc: Sean Paul <s...@poorly.run>
> > Cc: David Airlie <airl...@linux.ie>
> > Cc: Lyude Paul <ly...@redhat.com>
> > Cc: Karol Herbst <karolher...@gmail.com>
> > Cc: Ilia Mirkin <imir...@alum.mit.edu>
> > Cc: dri-de...@lists.freedesktop.org
> > Cc: intel-gfx@lists.freedesktop.org
> > Cc: linux-renesas-...@vger.kernel.org
> > Reported-by: kbuild test robot <l...@intel.com>
> > Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
> > Signed-off-by: Sean Paul <seanp...@chromium.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
>
> I have no pending conflicting changes for rcar_lvds.c. Do you plan to
> merge this through drm-misc ?
Thanks for your review!
Yeah, since the bug is only in drm-misc-next, this will also go there. Speaking
of which, I just applied it :-)
Sean
>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_lvds.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > index f2a5d4d997073..1c62578590f46 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > @@ -115,8 +115,8 @@ static int rcar_lvds_connector_atomic_check(struct
> > drm_connector *connector,
> >
> > /* We're not allowed to modify the resolution. */
> > crtc_state = drm_atomic_get_crtc_state(state, conn_state->crtc);
> > - if (!crtc_state)
> > - return -EINVAL;
> > + if (IS_ERR(crtc_state))
> > + return PTR_ERR(crtc_state);
> >
> > if (crtc_state->mode.hdisplay != panel_mode->hdisplay ||
> > crtc_state->mode.vdisplay != panel_mode->vdisplay)
>
> --
> Regards,
>
> Laurent Pinchart
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
