On Tue, 25 Jun 2019, Lee Shawn C <shawn.c....@intel.com> wrote: > Modify aux backlight enable/disable sequence just like what we > did for genernal eDP panel. Setup PWM freq and brightness level > before enable display backlight. > > v2: According to spec, it is not necessary to set PWM to 0 if > backlight enable already off. Remove intel_dp_aux_set_backlight to 0.
Please think it through again. The same applies here. The brightness change before enable is ignored according to eDP spec. BR, Jani. > > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Jani Nikula <jani.nik...@intel.com> > Cc: Jose Roberto de Souza <jose.so...@intel.com> > Cc: Cooper Chiou <cooper.ch...@intel.com> > > Signed-off-by: Lee Shawn C <shawn.c....@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index 6b0b73479fb8..70d9b9c9586f 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -216,8 +216,8 @@ static void intel_dp_aux_enable_backlight(const struct > intel_crtc_state *crtc_st > } > } > > - set_aux_backlight_enable(intel_dp, true); > intel_dp_aux_set_backlight(conn_state, > connector->panel.backlight.level); > + set_aux_backlight_enable(intel_dp, true); > } > > static void intel_dp_aux_disable_backlight(const struct drm_connector_state > *old_conn_state) -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
