Quoting Tvrtko Ursulin (2019-07-02 11:23:11) > From: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > > Some interrupt handling functions already have gt in their names > suggesting them as obvious candidates to make them take struct intel_gt > instead of i915. > > Signed-off-by: Paulo Zanoni <paulo.r.zan...@intel.com> > Co-authored-by: Paulo Zanoni <paulo.r.zan...@intel.com> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
> static void > -gen11_other_irq_handler(struct drm_i915_private * const i915, > - const u8 instance, const u16 iir) > +gen11_other_irq_handler(struct intel_gt *gt, const u8 instance, > + const u16 iir) > { > + struct drm_i915_private *i915 = gt->i915; > + > if (instance == OTHER_GUC_INSTANCE) > return gen11_guc_irq_handler(i915, iir); That looks like a candidate for gt as well. Even for the guc, the interrupt vector is GT centric. I was hoping we could place guc/ parallel to gt/, but it looks like it will indeed be a child of intel_gt. Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx