On Fri, Jul 12, 2019 at 03:55:01PM +0300, Ville Syrjälä wrote:
because the platform may not have the register bit that tells if the we
have modular FIA, as is the case with Ice Lake. The bit is reserved
there. This is actually "may_have_modular_fia" rather than
"has_modular_fia", but the name is pretty bad to make it that way.
Are we expecting this to ping-pong between various gen12+ platforms?
If not then IMO a flag is overkill.
I would not expect a ping pong, but I don't really know. Since currently
there's only one we can change the check to be gen >= 12. Or we can
leave as is and change it to be a gen check when next platforms come.
Lucas De Marchi
Lucas De Marchi
>
>Thanks,
>Stuart
>
>> func(has_overlay); \
>> func(has_psr); \
>> func(overlay_needs_physical); \
>> diff --git a/drivers/gpu/drm/i915/intel_drv.h
>> b/drivers/gpu/drm/i915/intel_drv.h
>> index 770f9f6aad84..e8ecbd55476e 100644
>> --- a/drivers/gpu/drm/i915/intel_drv.h
>> +++ b/drivers/gpu/drm/i915/intel_drv.h
>> @@ -1245,6 +1245,7 @@ struct intel_digital_port {
>> bool tc_legacy_port:1;
>> char tc_port_name[8];
>> enum tc_port_mode tc_mode;
>> + enum phy_fia tc_phy_fia;
>>
>> void (*write_infoframe)(struct intel_encoder *encoder,
>> const struct intel_crtc_state
>> *crtc_state,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
