Quoting Tvrtko Ursulin (2019-09-02 14:59:16) > > On 05/08/2019 18:08, Andi Shyti wrote: > > Hi Chris, > > > > On Tue, Jul 30, 2019 at 02:30:27PM +0100, Chris Wilson wrote: > >> Push the ring creation flags from the outer GEM context to the inner > >> intel_cotnext to avoid an unsightly back-reference from inside the > >> backend. > >> > >> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > > > looks nice! > > > > Reviewed-by: Andi Shyti <andi.sh...@intel.com> > > I wish my complaints on this patch weren't just ignored.
You wanted a union for a one-off value, and I disagreed as imo it overformalised the parameter passing and made it look like persistent state. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
