Op 25-09-2019 om 15:01 schreef Ville Syrjälä: > On Fri, Sep 20, 2019 at 01:42:17PM +0200, Maarten Lankhorst wrote: >> Now that we separated everything into uapi and hw, it's >> time to make the split definitive. Remove the union and >> make a copy of the hw state on modeset and fastset. >> >> Color blobs are copied in crtc atomic_check(), right >> before color management is checked. > Don't like. IMO there should be one and only one place where copy over > the uapi state into the hw state. Otherwise it's a mess because you > constantly have to remind yourself which bits of state already got > copied and which didn't.
Yeah it's a tad annoying, can always just do it in this loop. We either copy full state on modeset or just the blobs.. Will send a new version. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
