On Tue, Oct 01, 2019 at 11:07:39AM +0300, Jani Nikula wrote: > The kernel has plenty of ternary operators to choose between constant > strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : > "s": > > $ git grep '? "yes" : "no"' | wc -l > 258 > $ git grep '? "on" : "off"' | wc -l > 204 > $ git grep '? "enabled" : "disabled"' | wc -l > 196 > $ git grep '? "" : "s"' | wc -l > 25 > > Additionally, there are some occurences of the same in reverse order, > split to multiple lines, or otherwise not caught by the simple grep. > > Add helpers to return the constant strings. Remove existing equivalent > and conflicting functions in i915, cxgb4, and USB core. Further > conversion can be done incrementally. > > While the main goal here is to abstract recurring patterns, and slightly > clean up the code base by not open coding the ternary operators, there > are also some space savings to be had via better string constant > pooling. > > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Cc: Vishal Kulkarni <vis...@chelsio.com> > Cc: net...@vger.kernel.org > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: linux-...@vger.kernel.org > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: linux-ker...@vger.kernel.org > Cc: Julia Lawall <julia.law...@lip6.fr> > Cc: Rasmus Villemoes <li...@rasmusvillemoes.dk> > Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> # v1
As this is a totally different version, please drop my reviewed-by as that's really not true here :(
