get_crtc_from_states() is called before plane_state is copied to uapi,
so use the uapi state there.

intel_legacy_cursor_update() could probably get away with looking at
the hw state, but for clarity look at the uapi state always

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_atomic_plane.c | 8 ++++----
 drivers/gpu/drm/i915/display/intel_display.c      | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c 
b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 4b12eeb6850d..0db20da7781c 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -186,11 +186,11 @@ static struct intel_crtc *
 get_crtc_from_states(const struct intel_plane_state *old_plane_state,
                     const struct intel_plane_state *new_plane_state)
 {
-       if (new_plane_state->base.crtc)
-               return to_intel_crtc(new_plane_state->base.crtc);
+       if (new_plane_state->uapi.crtc)
+               return to_intel_crtc(new_plane_state->uapi.crtc);
 
-       if (old_plane_state->base.crtc)
-               return to_intel_crtc(old_plane_state->base.crtc);
+       if (old_plane_state->uapi.crtc)
+               return to_intel_crtc(old_plane_state->uapi.crtc);
 
        return NULL;
 }
diff --git a/drivers/gpu/drm/i915/display/intel_display.c 
b/drivers/gpu/drm/i915/display/intel_display.c
index 2dbc1df9505a..26f86989f652 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -15173,12 +15173,12 @@ intel_legacy_cursor_update(struct drm_plane *_plane,
         * take the slowpath. Only changing fb or position should be
         * in the fastpath.
         */
-       if (old_plane_state->base.crtc != &crtc->base ||
+       if (old_plane_state->uapi.crtc != &crtc->base ||
            old_plane_state->base.src_w != src_w ||
            old_plane_state->base.src_h != src_h ||
            old_plane_state->base.crtc_w != crtc_w ||
            old_plane_state->base.crtc_h != crtc_h ||
-           !old_plane_state->base.fb != !fb)
+           !old_plane_state->uapi.fb != !fb)
                goto slow;
 
        new_plane_state = 
to_intel_plane_state(intel_plane_duplicate_state(&plane->base));
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to