Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/uc: Move uC debugfs to its own folder under GT

[Andi Shyti]

Hi Daniele,

>  void debugfs_gt_register(struct intel_gt *gt)
> @@ -24,6 +25,8 @@ void debugfs_gt_register(struct intel_gt *gt)
>  
>       debugfs_engines_register(gt, root);
>       debugfs_gt_pm_register(gt, root);
> +
> +     intel_uc_debugfs_register(&gt->uc, root);
>  }
>  
>  void intel_gt_debugfs_register_files(struct dentry *root,
> @@ -31,9 +34,10 @@ void intel_gt_debugfs_register_files(struct dentry *root,
>                                    unsigned long count, void *data)
>  {
>       while (count--) {
> +             umode_t mode = files->fops->write ? 0644 : 0444;
>               if (!files->eval || files->eval(data))
>                       debugfs_create_file(files->name,
> -                                         0444, root, data,
> +                                         mode, root, data,
>                                           files->fops);

perhaps at some point we could send this to the debugfs framework
as multifile creation.

in any case,

Reviewed-by: Andi Shyti <andi.sh...@intel.com>

Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx