Quoting Chris Wilson (2020-05-20 13:01:35) > Quoting Tvrtko Ursulin (2020-05-20 12:54:19) > > > > On 20/05/2020 11:38, Chris Wilson wrote: > > > @@ -1083,10 +1154,10 @@ print_header(struct engines *engines, double t, > > > printf("\033[H\033[J"); > > > > > > if (lines++ < con_h) > > > - printf("intel-gpu-top - %s/%s MHz; %s%% RC6; %s > > > %s; %s irqs/s\n", > > > + printf("intel-gpu-top - %s/%s MHz; %s%% RC6; %s/%s > > > W; %s irqs/s\n", > > > > Detecting the unit was also a good thing to have so why drop it? > > Because I'm lazy and reused some packaged code rather than try and > repackage the code here. Even too lazy to add libigt_rapl.la.
Also, we would only ever report W or mW as the SI unit, the choose is ours and whatever we choose requires adjusting of the reported rapl scalefactor. Since we measure in seconds, the rapl scalefactor itself would have to convert from horsepower into J for the results to make sense, and defined that way. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx