== Series Details ==
Series: drm/i915/display: Avoid PSR and FBC features concurently.
URL : https://patchwork.freedesktop.org/series/78107/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
dee7c897c6ed drm/i915/display: Avoid PSR and FBC features concurently.
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
#6:
Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. Panel
GIS
-:6: WARNING:TYPO_SPELLING: 'Enble' may be misspelled - perhaps 'Enable'?
#6:
Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. Panel
GIS
-:29: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
statements (8, 15)
#29: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1422:
+ if (i915_modparams.enable_psr) {
+ i915_modparams.enable_fbc = 0;
-:30: ERROR:CODE_INDENT: code indent should use tabs where possible
#30: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1423:
+ i915_modparams.enable_fbc = 0;$
-:30: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#30: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1423:
+ i915_modparams.enable_fbc = 0;$
-:31: ERROR:CODE_INDENT: code indent should use tabs where possible
#31: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1424:
+ DRM_DEBUG_KMS("PSR enabled. FBC no longer needed. Disable
FBC. \n");$
-:31: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#31: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1424:
+ DRM_DEBUG_KMS("PSR enabled. FBC no longer needed. Disable
FBC. \n");$
-:31: WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a
quoted newline
#31: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1424:
+ DRM_DEBUG_KMS("PSR enabled. FBC no longer needed. Disable
FBC. \n");
-:34: CHECK:LINE_SPACING: Please don't use multiple blank lines
#34: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1427:
+
+
-:53: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 3 errors, 6 warnings, 1 checks, 23 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
