[Intel-gfx] [PATCH 15/42] drm/i915/gt: Refactor heartbeat request construction and submission

[Chris Wilson]

Pull the individual strands of creating a custom heartbeat requests into
a pair of common functions. This will reduce the number of changes we
will need to make in future.

Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
---
 .../gpu/drm/i915/gt/intel_engine_heartbeat.c  | 56 +++++++++++++------
 1 file changed, 38 insertions(+), 18 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c 
b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
index 8ffdf676c0a0..eb4393b2342e 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
@@ -37,12 +37,33 @@ static bool next_heartbeat(struct intel_engine_cs *engine)
        return true;
 }
 
+static struct i915_request *
+heartbeat_create(struct intel_context *ce, gfp_t gfp)
+{
+       struct i915_request *rq;
+
+       intel_context_enter(ce);
+       rq = __i915_request_create(ce, gfp);
+       intel_context_exit(ce);
+
+       return rq;
+}
+
 static void idle_pulse(struct intel_engine_cs *engine, struct i915_request *rq)
 {
        engine->wakeref_serial = READ_ONCE(engine->serial) + 1;
        i915_request_add_active_barriers(rq);
 }
 
+static void heartbeat_commit(struct i915_request *rq,
+                            const struct i915_sched_attr *attr)
+{
+       idle_pulse(rq->engine, rq);
+
+       __i915_request_commit(rq);
+       __i915_request_queue(rq, attr);
+}
+
 static void show_heartbeat(const struct i915_request *rq,
                           struct intel_engine_cs *engine)
 {
@@ -137,18 +158,14 @@ static void heartbeat(struct work_struct *wrk)
                goto out;
        }
 
-       intel_context_enter(ce);
-       rq = __i915_request_create(ce, GFP_NOWAIT | __GFP_NOWARN);
-       intel_context_exit(ce);
+       rq = heartbeat_create(ce, GFP_NOWAIT | __GFP_NOWARN);
        if (IS_ERR(rq))
                goto unlock;
 
-       idle_pulse(engine, rq);
        if (engine->i915->params.enable_hangcheck)
                engine->heartbeat.systole = i915_request_get(rq);
 
-       __i915_request_commit(rq);
-       __i915_request_queue(rq, &attr);
+       heartbeat_commit(rq, &attr);
 
 unlock:
        mutex_unlock(&ce->timeline->mutex);
@@ -220,19 +237,14 @@ int intel_engine_pulse(struct intel_engine_cs *engine)
                goto out_rpm;
        }
 
-       intel_context_enter(ce);
-       rq = __i915_request_create(ce, GFP_NOWAIT | __GFP_NOWARN);
-       intel_context_exit(ce);
+       rq = heartbeat_create(ce, GFP_NOWAIT | __GFP_NOWARN);
        if (IS_ERR(rq)) {
                err = PTR_ERR(rq);
                goto out_unlock;
        }
 
        __set_bit(I915_FENCE_FLAG_SENTINEL, &rq->fence.flags);
-       idle_pulse(engine, rq);
-
-       __i915_request_commit(rq);
-       __i915_request_queue(rq, &attr);
+       heartbeat_commit(rq, &attr);
        GEM_BUG_ON(rq->sched.attr.priority < I915_PRIORITY_BARRIER);
        err = 0;
 
@@ -245,8 +257,9 @@ int intel_engine_pulse(struct intel_engine_cs *engine)
 
 int intel_engine_flush_barriers(struct intel_engine_cs *engine)
 {
+       struct intel_context *ce = engine->kernel_context;
        struct i915_request *rq;
-       int err = 0;
+       int err;
 
        if (llist_empty(&engine->barrier_tasks))
                return 0;
@@ -254,15 +267,22 @@ int intel_engine_flush_barriers(struct intel_engine_cs 
*engine)
        if (!intel_engine_pm_get_if_awake(engine))
                return 0;
 
-       rq = i915_request_create(engine->kernel_context);
+       if (mutex_lock_interruptible(&ce->timeline->mutex)) {
+               err = -EINTR;
+               goto out_rpm;
+       }
+
+       rq = heartbeat_create(ce, GFP_KERNEL);
        if (IS_ERR(rq)) {
                err = PTR_ERR(rq);
-               goto out_rpm;
+               goto out_unlock;
        }
 
-       idle_pulse(engine, rq);
-       i915_request_add(rq);
+       heartbeat_commit(rq, NULL);
 
+       err = 0;
+out_unlock:
+       mutex_unlock(&ce->timeline->mutex);
 out_rpm:
        intel_engine_pm_put(engine);
        return err;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx