From: Ville Syrjälä <ville.syrj...@linux.intel.com>
Rename all the watermark related structs/enums specific to ilk-bdw
to have an ilk_ prefix rather than an intel_ prefix. Should make it
less confusing for everyone when it's clear where these things
get used.
Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
---
.../drm/i915/display/intel_display_types.h | 12 +--
drivers/gpu/drm/i915/i915_drv.h | 8 +-
drivers/gpu/drm/i915/intel_pm.c | 102 +++++++++---------
3 files changed, 60 insertions(+), 62 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
b/drivers/gpu/drm/i915/display/intel_display_types.h
index 4c25e2e4f4ee..6b31af60d24d 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -664,7 +664,7 @@ struct intel_crtc_scaler_state {
/* Flag to indicate mipi dsi periodic command mode where we do not get TE */
#define I915_MODE_FLAG_DSI_PERIODIC_CMD_MODE (1<<5)
-struct intel_wm_level {
+struct ilk_wm_level {
bool enable;
u16 pri_val;
u16 spr_val;
@@ -672,8 +672,8 @@ struct intel_wm_level {
u16 fbc_val;
};
-struct intel_pipe_wm {
- struct intel_wm_level wm[5];
+struct ilk_pipe_wm {
+ struct ilk_wm_level wm[5];
bool fbc_wm_enabled;
bool pipe_enabled;
bool sprites_enabled;
@@ -745,13 +745,13 @@ struct intel_crtc_wm_state {
* switching away from and the new
* configuration we're switching to.
*/
- struct intel_pipe_wm intermediate;
+ struct ilk_pipe_wm intermediate;
/*
* Optimal watermarks, programmed post-vblank
* when this state is committed.
*/
- struct intel_pipe_wm optimal;
+ struct ilk_pipe_wm optimal;
} ilk;
struct {
@@ -1147,7 +1147,7 @@ struct intel_crtc {
struct {
/* watermarks currently being used */
union {
- struct intel_pipe_wm ilk;
+ struct ilk_pipe_wm ilk;
struct vlv_wm_state vlv;
struct g4x_wm_state g4x;
} active;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bcd8650603d8..3a1b37c560e5 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -723,9 +723,9 @@ struct intel_vbt_data {
struct sdvo_device_mapping sdvo_mappings[2];
};
-enum intel_ddb_partitioning {
- INTEL_DDB_PART_1_2,
- INTEL_DDB_PART_5_6, /* IVB+ */
+enum ilk_ddb_partitioning {
+ ILK_DDB_PART_1_2,
+ ILK_DDB_PART_5_6, /* IVB+ */
};
struct ilk_wm_values {
@@ -733,7 +733,7 @@ struct ilk_wm_values {
u32 wm_lp[3];
u32 wm_lp_spr[3];
bool enable_fbc_wm;
- enum intel_ddb_partitioning partitioning;
+ enum ilk_ddb_partitioning partitioning;
};
struct g4x_pipe_wm {
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index a82fb812b8c7..536420327c66 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -65,7 +65,7 @@ struct skl_wm_params {
};
/* used in computing the new watermarks state */
-struct intel_wm_config {
+struct ilk_wm_config {
unsigned int num_pipes_active;
bool sprites_enabled;
bool sprites_scaled;
@@ -2694,8 +2694,8 @@ static u16 ilk_fbc_wm_reg_max(const struct
drm_i915_private *dev_priv)
/* Calculate the maximum primary/sprite plane watermark */
static u16 ilk_plane_wm_max(const struct drm_i915_private *dev_priv,
int level,
- const struct intel_wm_config *config,
- enum intel_ddb_partitioning ddb_partitioning,
+ const struct ilk_wm_config *config,
+ enum ilk_ddb_partitioning ddb_partitioning,
bool is_sprite)
{
u16 fifo_size = ilk_display_fifo_size(dev_priv);
@@ -2719,7 +2719,7 @@ static u16 ilk_plane_wm_max(const struct drm_i915_private
*dev_priv,
if (config->sprites_enabled) {
/* level 0 is always calculated with 1:1 split */
- if (level > 0 && ddb_partitioning == INTEL_DDB_PART_5_6) {
+ if (level > 0 && ddb_partitioning == ILK_DDB_PART_5_6) {
if (is_sprite)
fifo_size *= 5;
fifo_size /= 6;
@@ -2735,7 +2735,7 @@ static u16 ilk_plane_wm_max(const struct drm_i915_private
*dev_priv,
/* Calculate the maximum cursor plane watermark */
static u16 ilk_cursor_wm_max(const struct drm_i915_private *dev_priv,
int level,
- const struct intel_wm_config *config)
+ const struct ilk_wm_config *config)
{
/* HSW LP1+ watermarks w/ multiple pipes */
if (level > 0 && config->num_pipes_active > 1)
@@ -2747,8 +2747,8 @@ static u16 ilk_cursor_wm_max(const struct
drm_i915_private *dev_priv,
static void ilk_compute_wm_maximums(const struct drm_i915_private *dev_priv,
int level,
- const struct intel_wm_config *config,
- enum intel_ddb_partitioning
ddb_partitioning,
+ const struct ilk_wm_config *config,
+ enum ilk_ddb_partitioning ddb_partitioning,
struct ilk_wm_maximums *max)
{
max->pri = ilk_plane_wm_max(dev_priv, level, config, ddb_partitioning,
false);
@@ -2769,7 +2769,7 @@ static void ilk_compute_wm_reg_maximums(const struct
drm_i915_private *dev_priv,
static bool ilk_validate_wm_level(int level,
const struct ilk_wm_maximums *max,
- struct intel_wm_level *result)
+ struct ilk_wm_level *result)
{
bool ret;
@@ -2815,7 +2815,7 @@ static void ilk_compute_wm_level(const struct
drm_i915_private *dev_priv,
const struct intel_plane_state *pristate,
const struct intel_plane_state *sprstate,
const struct intel_plane_state *curstate,
- struct intel_wm_level *result)
+ struct ilk_wm_level *result)
{
u16 pri_latency = dev_priv->wm.pri_latency[level];
u16 spr_latency = dev_priv->wm.spr_latency[level];
@@ -3114,10 +3114,10 @@ static void skl_setup_wm_latency(struct
drm_i915_private *dev_priv)
}
static bool ilk_validate_pipe_wm(const struct drm_i915_private *dev_priv,
- struct intel_pipe_wm *pipe_wm)
+ struct ilk_pipe_wm *pipe_wm)
{
/* LP0 watermark maximums depend on this pipe alone */
- const struct intel_wm_config config = {
+ const struct ilk_wm_config config = {
.num_pipes_active = 1,
.sprites_enabled = pipe_wm->sprites_enabled,
.sprites_scaled = pipe_wm->sprites_scaled,
@@ -3125,7 +3125,7 @@ static bool ilk_validate_pipe_wm(const struct
drm_i915_private *dev_priv,
struct ilk_wm_maximums max;
/* LP0 watermarks always use 1/2 DDB partitioning */
- ilk_compute_wm_maximums(dev_priv, 0, &config, INTEL_DDB_PART_1_2, &max);
+ ilk_compute_wm_maximums(dev_priv, 0, &config, ILK_DDB_PART_1_2, &max);
/* At least LP0 must be valid */
if (!ilk_validate_wm_level(0, &max, &pipe_wm->wm[0])) {
@@ -3141,7 +3141,7 @@ static int ilk_compute_pipe_wm(struct intel_crtc_state
*crtc_state)
{
struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev);
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
- struct intel_pipe_wm *pipe_wm;
+ struct ilk_pipe_wm *pipe_wm;
struct intel_plane *plane;
const struct intel_plane_state *plane_state;
const struct intel_plane_state *pristate = NULL;
@@ -3189,7 +3189,7 @@ static int ilk_compute_pipe_wm(struct intel_crtc_state
*crtc_state)
ilk_compute_wm_reg_maximums(dev_priv, 1, &max);
for (level = 1; level <= usable_level; level++) {
- struct intel_wm_level *wm = &pipe_wm->wm[level];
+ struct ilk_wm_level *wm = &pipe_wm->wm[level];
ilk_compute_wm_level(dev_priv, crtc, level, crtc_state,
pristate, sprstate, curstate, wm);
@@ -3217,12 +3217,12 @@ static int ilk_compute_intermediate_wm(struct
intel_crtc_state *newstate)
{
struct intel_crtc *intel_crtc = to_intel_crtc(newstate->uapi.crtc);
struct drm_i915_private *dev_priv = to_i915(intel_crtc->base.dev);
- struct intel_pipe_wm *a = &newstate->wm.ilk.intermediate;
+ struct ilk_pipe_wm *a = &newstate->wm.ilk.intermediate;
struct intel_atomic_state *intel_state =
to_intel_atomic_state(newstate->uapi.state);
const struct intel_crtc_state *oldstate =
intel_atomic_get_old_crtc_state(intel_state, intel_crtc);
- const struct intel_pipe_wm *b = &oldstate->wm.ilk.optimal;
+ const struct ilk_pipe_wm *b = &oldstate->wm.ilk.optimal;
int level, max_level = ilk_wm_max_level(dev_priv);
/*
@@ -3240,8 +3240,8 @@ static int ilk_compute_intermediate_wm(struct
intel_crtc_state *newstate)
a->sprites_scaled |= b->sprites_scaled;
for (level = 0; level <= max_level; level++) {
- struct intel_wm_level *a_wm = &a->wm[level];
- const struct intel_wm_level *b_wm = &b->wm[level];
+ struct ilk_wm_level *a_wm = &a->wm[level];
+ const struct ilk_wm_level *b_wm = &b->wm[level];
a_wm->enable &= b_wm->enable;
a_wm->pri_val = max(a_wm->pri_val, b_wm->pri_val);
@@ -3274,15 +3274,15 @@ static int ilk_compute_intermediate_wm(struct
intel_crtc_state *newstate)
*/
static void ilk_merge_wm_level(struct drm_i915_private *dev_priv,
int level,
- struct intel_wm_level *ret_wm)
+ struct ilk_wm_level *ret_wm)
{
const struct intel_crtc *intel_crtc;
ret_wm->enable = true;
for_each_intel_crtc(&dev_priv->drm, intel_crtc) {
- const struct intel_pipe_wm *active = &intel_crtc->wm.active.ilk;
- const struct intel_wm_level *wm = &active->wm[level];
+ const struct ilk_pipe_wm *active = &intel_crtc->wm.active.ilk;
+ const struct ilk_wm_level *wm = &active->wm[level];
if (!active->pipe_enabled)
continue;
@@ -3306,9 +3306,9 @@ static void ilk_merge_wm_level(struct drm_i915_private
*dev_priv,
* Merge all low power watermarks for all active pipes.
*/
static void ilk_wm_merge(struct drm_i915_private *dev_priv,
- const struct intel_wm_config *config,
+ const struct ilk_wm_config *config,
const struct ilk_wm_maximums *max,
- struct intel_pipe_wm *merged)
+ struct ilk_pipe_wm *merged)
{
int level, max_level = ilk_wm_max_level(dev_priv);
int last_enabled_level = max_level;
@@ -3323,7 +3323,7 @@ static void ilk_wm_merge(struct drm_i915_private
*dev_priv,
/* merge each WM1+ level */
for (level = 1; level <= max_level; level++) {
- struct intel_wm_level *wm = &merged->wm[level];
+ struct ilk_wm_level *wm = &merged->wm[level];
ilk_merge_wm_level(dev_priv, level, wm);
@@ -3353,14 +3353,14 @@ static void ilk_wm_merge(struct drm_i915_private
*dev_priv,
if (IS_GEN(dev_priv, 5) && !merged->fbc_wm_enabled &&
intel_fbc_is_active(dev_priv)) {
for (level = 2; level <= max_level; level++) {
- struct intel_wm_level *wm = &merged->wm[level];
+ struct ilk_wm_level *wm = &merged->wm[level];
wm->enable = false;
}
}
}
-static int ilk_wm_lp_to_level(int wm_lp, const struct intel_pipe_wm *pipe_wm)
+static int ilk_wm_lp_to_level(int wm_lp, const struct ilk_pipe_wm *pipe_wm)
{
/* LP1,LP2,LP3 levels are either 1,2,3 or 1,3,4 */
return wm_lp + (wm_lp >= 2 && pipe_wm->wm[4].enable);
@@ -3377,11 +3377,11 @@ static unsigned int ilk_wm_lp_latency(struct
drm_i915_private *dev_priv,
}
static void ilk_compute_wm_results(struct drm_i915_private *dev_priv,
- const struct intel_pipe_wm *merged,
- enum intel_ddb_partitioning partitioning,
+ const struct ilk_pipe_wm *merged,
+ enum ilk_ddb_partitioning partitioning,
struct ilk_wm_values *results)
{
- struct intel_crtc *intel_crtc;
+ struct intel_crtc *crtc;
int level, wm_lp;
results->enable_fbc_wm = merged->fbc_wm_enabled;
@@ -3389,7 +3389,7 @@ static void ilk_compute_wm_results(struct
drm_i915_private *dev_priv,
/* LP1+ register values */
for (wm_lp = 1; wm_lp <= 3; wm_lp++) {
- const struct intel_wm_level *r;
+ const struct ilk_wm_level *r;
level = ilk_wm_lp_to_level(wm_lp, merged);
@@ -3426,10 +3426,9 @@ static void ilk_compute_wm_results(struct
drm_i915_private *dev_priv,
}
/* LP0 register values */
- for_each_intel_crtc(&dev_priv->drm, intel_crtc) {
- enum pipe pipe = intel_crtc->pipe;
- const struct intel_pipe_wm *pipe_wm =
&intel_crtc->wm.active.ilk;
- const struct intel_wm_level *r = &pipe_wm->wm[0];
+ for_each_intel_crtc(&dev_priv->drm, crtc) {
+ const struct ilk_wm_level *r = &crtc->wm.active.ilk.wm[0];
+ enum pipe pipe = crtc->pipe;
if (drm_WARN_ON(&dev_priv->drm, !r->enable))
continue;
@@ -3443,10 +3442,10 @@ static void ilk_compute_wm_results(struct
drm_i915_private *dev_priv,
/* Find the result with the highest level enabled. Check for enable_fbc_wm in
* case both are at the same level. Prefer r1 in case they're the same. */
-static struct intel_pipe_wm *
+static struct ilk_pipe_wm *
ilk_find_best_result(struct drm_i915_private *dev_priv,
- struct intel_pipe_wm *r1,
- struct intel_pipe_wm *r2)
+ struct ilk_pipe_wm *r1,
+ struct ilk_pipe_wm *r2)
{
int level, max_level = ilk_wm_max_level(dev_priv);
int level1 = 0, level2 = 0;
@@ -3580,14 +3579,14 @@ static void ilk_write_wm_values(struct drm_i915_private
*dev_priv,
if (dirty & WM_DIRTY_DDB) {
if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) {
val = I915_READ(WM_MISC);
- if (results->partitioning == INTEL_DDB_PART_1_2)
+ if (results->partitioning == ILK_DDB_PART_1_2)
val &= ~WM_MISC_DATA_PARTITION_5_6;
else
val |= WM_MISC_DATA_PARTITION_5_6;
I915_WRITE(WM_MISC, val);
} else {
val = I915_READ(DISP_ARB_CTL2);
- if (results->partitioning == INTEL_DDB_PART_1_2)
+ if (results->partitioning == ILK_DDB_PART_1_2)
val &= ~DISP_DATA_PARTITION_5_6;
else
val |= DISP_DATA_PARTITION_5_6;
@@ -6135,13 +6134,13 @@ skl_compute_wm(struct intel_atomic_state *state)
}
static void ilk_compute_wm_config(struct drm_i915_private *dev_priv,
- struct intel_wm_config *config)
+ struct ilk_wm_config *config)
{
struct intel_crtc *crtc;
/* Compute the currently _active_ config */
for_each_intel_crtc(&dev_priv->drm, crtc) {
- const struct intel_pipe_wm *wm = &crtc->wm.active.ilk;
+ const struct ilk_pipe_wm *wm = &crtc->wm.active.ilk;
if (!wm->pipe_enabled)
continue;
@@ -6154,21 +6153,21 @@ static void ilk_compute_wm_config(struct
drm_i915_private *dev_priv,
static void ilk_program_watermarks(struct drm_i915_private *dev_priv)
{
- struct intel_pipe_wm lp_wm_1_2 = {}, lp_wm_5_6 = {}, *best_lp_wm;
+ struct ilk_pipe_wm lp_wm_1_2 = {}, lp_wm_5_6 = {}, *best_lp_wm;
struct ilk_wm_maximums max;
- struct intel_wm_config config = {};
+ struct ilk_wm_config config = {};
struct ilk_wm_values results = {};
- enum intel_ddb_partitioning partitioning;
+ enum ilk_ddb_partitioning partitioning;
ilk_compute_wm_config(dev_priv, &config);
- ilk_compute_wm_maximums(dev_priv, 1, &config, INTEL_DDB_PART_1_2, &max);
+ ilk_compute_wm_maximums(dev_priv, 1, &config, ILK_DDB_PART_1_2, &max);
ilk_wm_merge(dev_priv, &config, &max, &lp_wm_1_2);
/* 5/6 split only in single pipe config on IVB+ */
if (INTEL_GEN(dev_priv) >= 7 &&
config.num_pipes_active == 1 && config.sprites_enabled) {
- ilk_compute_wm_maximums(dev_priv, 1, &config,
INTEL_DDB_PART_5_6, &max);
+ ilk_compute_wm_maximums(dev_priv, 1, &config, ILK_DDB_PART_5_6,
&max);
ilk_wm_merge(dev_priv, &config, &max, &lp_wm_5_6);
best_lp_wm = ilk_find_best_result(dev_priv, &lp_wm_1_2,
&lp_wm_5_6);
@@ -6177,7 +6176,7 @@ static void ilk_program_watermarks(struct
drm_i915_private *dev_priv)
}
partitioning = (best_lp_wm == &lp_wm_1_2) ?
- INTEL_DDB_PART_1_2 : INTEL_DDB_PART_5_6;
+ ILK_DDB_PART_1_2 : ILK_DDB_PART_5_6;
ilk_compute_wm_results(dev_priv, best_lp_wm, partitioning, &results);
@@ -6279,11 +6278,10 @@ void skl_wm_get_hw_state(struct drm_i915_private
*dev_priv)
static void ilk_pipe_wm_get_hw_state(struct intel_crtc *crtc)
{
- struct drm_device *dev = crtc->base.dev;
- struct drm_i915_private *dev_priv = to_i915(dev);
+ struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
struct ilk_wm_values *hw = &dev_priv->wm.hw;
struct intel_crtc_state *crtc_state =
to_intel_crtc_state(crtc->base.state);
- struct intel_pipe_wm *active = &crtc_state->wm.ilk.optimal;
+ struct ilk_pipe_wm *active = &crtc_state->wm.ilk.optimal;
enum pipe pipe = crtc->pipe;
hw->wm_pipe[pipe] = I915_READ(WM0_PIPE_ILK(pipe));
@@ -6757,10 +6755,10 @@ void ilk_wm_get_hw_state(struct drm_i915_private
*dev_priv)
if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
hw->partitioning = (I915_READ(WM_MISC) &
WM_MISC_DATA_PARTITION_5_6) ?
- INTEL_DDB_PART_5_6 : INTEL_DDB_PART_1_2;
+ ILK_DDB_PART_5_6 : ILK_DDB_PART_1_2;
else if (IS_IVYBRIDGE(dev_priv))
hw->partitioning = (I915_READ(DISP_ARB_CTL2) &
DISP_DATA_PARTITION_5_6) ?
- INTEL_DDB_PART_5_6 : INTEL_DDB_PART_1_2;
+ ILK_DDB_PART_5_6 : ILK_DDB_PART_1_2;
hw->enable_fbc_wm =
!(I915_READ(DISP_ARB_CTL) & DISP_FBC_WM_DIS);
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
