On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner <t...@linutronix.de> wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant for the chip while using the irq descriptor variant > returns the irq chip data of the top level chip of a hierarchy. It does not > matter in this case because the chip is the top level chip, but that > doesn't make it more correct. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Cc: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> > Cc: Rob Herring <r...@kernel.org> > Cc: Bjorn Helgaas <bhelg...@google.com> > Cc: Michal Simek <michal.si...@xilinx.com> > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > --- > drivers/pci/controller/pcie-xilinx-nwl.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Rob Herring <r...@kernel.org> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
