On Fri, Aug 30, 2013 at 08:40:36PM -0700, Ben Widawsky wrote: > On Sat, Aug 31, 2013 at 01:12:55AM +0100, Chris Wilson wrote: > > On Fri, Aug 30, 2013 at 04:43:59PM -0700, Ben Widawsky wrote: > > > From: Ben Widawsky <b...@bwidawsk.net> > > > > > > As we plumb the code with more VM information, it has become more > > > obvious that the easiest way to deal with bind and unbind is to simply > > > put the function pointers in the vm, and let those choose the correct > > > way to handle the page table updates. This change allows many places in > > > the code to simply be vm->bind, and not have to worry about > > > distinguishing PPGTT vs GGTT. > > > > > > Notice that this patch has no impact on functionality. I've decided to > > > save the actual change until the next patch because I think it's easier > > > to review that way. I'm happy to squash the two, or let Daniel do it on > > > merge. > > > > > > v2: > > > Make ggtt handle the quirky aliasing ppgtt > > > Add flags to bind object to support above > > > Don't ever call bind/unbind directly for PPGTT until we have real, full > > > PPGTT (use NULLs to assert this) > > > Make sure we rebind the ggtt if there already is a ggtt binding. This > > > happens on set cache levels > > > Use VMA for bind/unbind (Daniel, Ben) > > > > > > Signed-off-by: Ben Widawsky <b...@bwidawsk.net> > > > > You like pokkadot paint for its inconsistency? Other than interesting > > alternation of styles, I see nothing wrong with the logic. > > -Chris > > > > To what are you referring? I'm probably more than willing to change > whatever displeases you.
You were alternating between using temporary variables like const unsigned long entry = vma->node.start >> PAGE_SHIFT; and doing the computation inline, with no consistency as far as I could see. It was so very minor, but it looks like cut'n'paste code from multiple sources. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
