On 17.08.2021 19:20, Daniel Vetter wrote: > On Tue, Aug 17, 2021 at 09:36:49AM -0700, Matthew Brost wrote: >> On Tue, Aug 17, 2021 at 01:11:41PM +0200, Daniel Vetter wrote: >>> On Mon, Aug 16, 2021 at 06:51:39AM -0700, Matthew Brost wrote: >>>> Add GuC kernel doc for all structures added thus far for GuC submission >>>> and update the main GuC submission section with the new interface >>>> details. >>>> >>>> Signed-off-by: Matthew Brost <matthew.br...@intel.com> >>> >>> There's quite a bit more, e.g. intel_guc_ct, which has it's own world of >>> locking design that also doesn't feel too consistent. >>> >> >> That is a different layer than GuC submission so I don't we should >> mention anything about that layer here. Didn't really write that layer >> and it super painful to touch that code so I'm going to stay out of any >> rework you think we need to do there. > > Well there's three locks It's likely me. There is one lock for the recv CTB, one for the send CTB, one for the list of read messages ready to post process - do you want to use single lock for both CTBs or single lock for all cases in CT ? Michal disclaimer: outstanding_g2h are not part of the CTB layer > there plus it leaks out (you have your > outstanding_submission_g2h atomic_t which is very closed tied to well, > outstanding guc transmissions), so I guess I need someone else for that? >
- [Intel-gfx] [PATCH 19/22] drm/i915/guc: Proper xarray us... Matthew Brost
- Re: [Intel-gfx] [PATCH 19/22] drm/i915/guc: Proper ... Daniel Vetter
- Re: [Intel-gfx] [PATCH 19/22] drm/i915/guc: Pro... Matthew Brost
- Re: [Intel-gfx] [PATCH 19/22] drm/i915/guc:... Daniel Vetter
- Re: [Intel-gfx] [PATCH 19/22] drm/i915/... Matthew Brost
- [Intel-gfx] [PATCH 11/22] drm/i915/guc: Take context ref... Matthew Brost
- [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC kernel d... Matthew Brost
- Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add GuC... Daniel Vetter
- Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc: Add... Matthew Brost
- Re: [Intel-gfx] [PATCH 22/22] drm/i915/guc:... Daniel Vetter
- Re: [Intel-gfx] [PATCH 22/22] drm/i915/... Michal Wajdeczko
- Re: [Intel-gfx] [PATCH 22/22] drm/... Daniel Vetter
- Re: [Intel-gfx] [PATCH 22/22] ... Michal Wajdeczko
- Re: [Intel-gfx] [PATCH 22/22] ... Daniel Vetter
- [Intel-gfx] [PATCH 15/22] drm/i915/guc: Flush G2H work q... Matthew Brost
- Re: [Intel-gfx] [PATCH 15/22] drm/i915/guc: Flush G... Daniel Vetter
- [Intel-gfx] [PATCH 12/22] drm/i915/guc: Don't touch guc_... Matthew Brost
- Re: [Intel-gfx] [PATCH 12/22] drm/i915/guc: Don't t... kernel test robot
- [Intel-gfx] [PATCH 17/22] drm/i915/guc: Move guc_blocked... Matthew Brost
- Re: [Intel-gfx] [PATCH 17/22] drm/i915/guc: Move gu... Daniel Vetter
- [Intel-gfx] [PATCH 20/22] drm/i915/guc: Drop pin count c... Matthew Brost