Hi Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next 
tegra-drm/drm/tegra/for-next linus/master airlied/drm-next v5.15-rc3 
next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211005-061424
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-a003-20211004 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 
c0039de2953d15815448b4b3c3bafb45607781e0)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/3bea3cc438df1105d0d8c1bcc01b96559d4bb78c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211005-061424
        git checkout 3bea3cc438df1105d0d8c1bcc01b96559d4bb78c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 
ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1486:7: error: variable 
>> 'ret' is used uninitialized whenever 'if' condition is false 
>> [-Werror,-Wsometimes-uninitialized]
                   if (multi_lrc_submit(rq)) {
                       ^~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1499:9: note: 
uninitialized use occurs here
           return ret;
                  ^~~
   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1486:3: note: remove the 
'if' if its condition is always true
                   if (multi_lrc_submit(rq)) {
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1479:9: note: initialize 
the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
   1 error generated.


vim +1486 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

  1475  
  1476  static int guc_bypass_tasklet_submit(struct intel_guc *guc,
  1477                                       struct i915_request *rq)
  1478  {
  1479          int ret;
  1480  
  1481          __i915_request_submit(rq);
  1482  
  1483          trace_i915_request_in(rq, 0);
  1484  
  1485          if (is_multi_lrc_rq(rq)) {
> 1486                  if (multi_lrc_submit(rq)) {
  1487                          ret = guc_wq_item_append(guc, rq);
  1488                          if (!ret)
  1489                                  ret = guc_add_request(guc, rq);
  1490                  }
  1491          } else {
  1492                  guc_set_lrc_tail(rq);
  1493                  ret = guc_add_request(guc, rq);
  1494          }
  1495  
  1496          if (unlikely(ret == -EPIPE))
  1497                  disable_submission(guc);
  1498  
  1499          return ret;
  1500  }
  1501  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to