[Intel-gfx] [PATCH 10/22] drm/msm: Nuke weird on stack mode copy

[Ville Syrjala]

From: Ville Syrjälä <ville.syrj...@linux.intel.com>

This on stack middle man mode looks entirely pointless.
Just duplicate the original mode directly.

Cc: Rob Clark <robdcl...@gmail.com>
Cc: Sean Paul <s...@poorly.run>
Cc: Abhinav Kumar <quic_abhin...@quicinc.com>
Cc: linux-arm-...@vger.kernel.org
Cc: freedr...@lists.freedesktop.org
Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
---
 drivers/gpu/drm/msm/dp/dp_drm.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
index d4d360d19eba..09188d02aa1e 100644
--- a/drivers/gpu/drm/msm/dp/dp_drm.c
+++ b/drivers/gpu/drm/msm/dp/dp_drm.c
@@ -56,7 +56,7 @@ static int dp_connector_get_modes(struct drm_connector 
*connector)
        int rc = 0;
        struct msm_dp *dp;
        struct dp_display_mode *dp_mode = NULL;
-       struct drm_display_mode *m, drm_mode;
+       struct drm_display_mode *m;
 
        if (!connector)
                return 0;
@@ -82,13 +82,11 @@ static int dp_connector_get_modes(struct drm_connector 
*connector)
                        return rc;
                }
                if (dp_mode->drm_mode.clock) { /* valid DP mode */
-                       memset(&drm_mode, 0x0, sizeof(drm_mode));
-                       drm_mode_copy(&drm_mode, &dp_mode->drm_mode);
-                       m = drm_mode_duplicate(connector->dev, &drm_mode);
+                       m = drm_mode_duplicate(connector->dev, 
&dp_mode->drm_mode);
                        if (!m) {
                                DRM_ERROR("failed to add mode %ux%u\n",
-                                      drm_mode.hdisplay,
-                                      drm_mode.vdisplay);
+                                         dp_mode->drm_mode.hdisplay,
+                                         dp_mode->drm_mode.vdisplay);
                                kfree(dp_mode);
                                return 0;
                        }
-- 
2.34.1