Daniel Vetter <dan...@ffwll.ch> writes: > Hi Ben > > So first things first: I rather like what the code looks like overall at > the end. I've done a light read-through (by far not a full review) and > besides a few bikesheds (all mentioned by mail already) the big thing is > the 1:1 context:ppgtt address space relationship. > > We've discussed this at length in private irc and agreed that we need to > changes this two a n:1 relationship, so I'll just reiterate the reasons > for that on the list: > > - Current userspace expects that different contexts created on the same fd > all use the same address space (since there's really only one). So if we > want to no add a new ABI (and for testing I really think we want to > enable ppgtt on current unchanged userspace) we must keep that promise. > Hence we need to be able to point the different contexts created on an > fd all at the same (per-fd) address space.
I'm not coming up with anything in userland requiring this. Can you clarify? For the GL context reset stuff, it is required that we have more than one address space per fd, because the fd is global to all contexts, not just a share group.
pgpRgg39_COzQ.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
