Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

[Dixit, Ashutosh]

On Sun, 24 Apr 2022 11:43:18 -0700, Andi Shyti wrote:
>
> Hi Ashutosh,

Hi Andi

> [...]
>
> >  static int intel_sysfs_rps_init(struct intel_gt *gt, struct kobject *kobj,
> >                             const struct attribute * const *attrs)
> >  {
> > @@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, 
> > struct kobject *kobj)
> >             drm_warn(&gt->i915->drm,
> >                      "failed to create gt%u throttle sysfs files (%pe)",
> >                      gt->info.id, ERR_PTR(ret));
> > +
> > +   if (HAS_MEDIA_RATIO_MODE(gt->i915) && intel_uc_uses_guc_slpc(&gt->uc)) {
>
> you could use in this case the ".is_visible()" function as you are
> not inheriting it from the upper drm class.

".is_visible()" is only available in an "attribute_group" but here we are
not creating an "attribute_group", just creating files in a previously
existing sysfs directory (i.e. using using sysfs_create_files() (as done
for RPS attributes) rather than sysfs_create_group() (as done for
RC6)). There seems to be no reason to create an "attribute_group" (such as
what was needed for RC6) so unless you suggest otherwise I'm leaving this
as is.

>
> Anyway,
>
> Reviewed-by: Andi Shyti <andi.sh...@linux.intel.com>

Thanks.
--
Ashutosh