Re: [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON()

[Tvrtko Ursulin]

On 04/05/2022 19:37, Jani Nikula wrote:

There are already too many choices here, take away the unused ones.

Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nik...@intel.com>
---
  drivers/gpu/drm/i915/i915_gem.h | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
index d0752e5553db..b7b257f54d2e 100644
--- a/drivers/gpu/drm/i915/i915_gem.h
+++ b/drivers/gpu/drm/i915/i915_gem.h
@@ -54,9 +54,7 @@ struct drm_i915_private;
        } while(0)
  #define GEM_WARN_ON(expr) WARN_ON(expr)

-#define GEM_DEBUG_DECL(var) var

  #define GEM_DEBUG_EXEC(expr) expr
-#define GEM_DEBUG_BUG_ON(expr) GEM_BUG_ON(expr)
  #define GEM_DEBUG_WARN_ON(expr) GEM_WARN_ON(expr)

#else

@@ -66,9 +64,7 @@ struct drm_i915_private;
  #define GEM_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr)
  #define GEM_WARN_ON(expr) ({ unlikely(!!(expr)); })

-#define GEM_DEBUG_DECL(var)

  #define GEM_DEBUG_EXEC(expr) do { } while (0)
-#define GEM_DEBUG_BUG_ON(expr)
  #define GEM_DEBUG_WARN_ON(expr) ({ BUILD_BUG_ON_INVALID(expr); 0; })
  #endif

Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com>

Regards,

Tvrtko