On 2013.11.20 11:36:20 +0000, Damien Lespiau wrote: > On Wed, Nov 20, 2013 at 05:22:48PM +0800, Zhenyu Wang wrote: > > If valgrind is not available, current VG_CLEAR() would just ignore > > memory clear operation which might make invalid ioctl argument. So > > make sure VG_CLEAR() will always clear memory. > > --- > > intel/intel_bufmgr_gem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c > > index df6fcec..389f73a 100644 > > --- a/intel/intel_bufmgr_gem.c > > +++ b/intel/intel_bufmgr_gem.c > > @@ -74,7 +74,7 @@ > > #define VG(x) > > #endif > > > > -#define VG_CLEAR(s) VG(memset(&s, 0, sizeof(s))) > > +#define VG_CLEAR(s) (memset(&s, 0, sizeof(s))) > > VG_CLEAR() is really just for valgrind. If you need to set some specific > variable/field to 0 then you need to set it to 0 and not rely on > VG_CLEAR() to do it for you. >
ok, in valgrind case it does memory clear for ioctl args which I think is good behavior in non-valgrind case too. > What's the actual issue you have? > During testing on recent get reset status ioctl, if !HAVE_VALGRIND, stats argument is not cleared, which failed in kernel check. -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
signature.asc
Description: Digital signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
