On Tue, Aug 30, 2022 at 06:15:44AM +0000, Murthy, Arun R wrote: > > -----Original Message----- > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > Sent: Wednesday, August 24, 2022 5:48 PM > > To: Murthy, Arun R <arun.r.mur...@intel.com> > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma <uma.shan...@intel.com> > > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers > > > > On Wed, Aug 24, 2022 at 03:02:33AM +0000, Murthy, Arun R wrote: > > > > -----Original Message----- > > > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > > Sent: Tuesday, August 23, 2022 6:27 PM > > > > To: Murthy, Arun R <arun.r.mur...@intel.com> > > > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > > > <uma.shan...@intel.com> > > > > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear > > > > buffers > > > > > > > > On Mon, Jul 04, 2022 at 09:45:48PM +0530, Arun R Murthy wrote: > > > > > Intel Gen do support Async Flip is supported on linear buffers. > > > > > Since we didn't had a use case, it was not enabled. Now that as > > > > > part of hybrid graphics for unsupported hardware pixel formats, > > > > > its being converted to linear memory and then flipped, hence enabling! > > > > > This patch enables support for async on linear buffer. > > > > > > > > > > v2: added use case > > > > > v3: enabled async on linear for pre Gen 12 as well > > > > > > > > I didn't think it went all the way back to gen9? > > > > > > > It's the same as other buffers. I have just added support for linear > > > buffer in > > the present async flip path, so the platforms on which the async flip is > > supported will support linear buffer as well. > > > > I know what the patch does. But I don't think bspec agrees with it. > > > I initially had this async on linear buffer support from Gen12 onwards. Will > add that check back.
We're just going in circles here. What I've asked repeatedly is actual justification for whatever gen check or no gen check there is. Ie. please *read* the bspec and include the appropriate information in the patch. Otherwise there is no point in me even looking at these patches anymore. > > > > > > > > Also we still don't seem to have any tests for this stuff... > > > > > > There is an IGT patch in queue, once this patch is merged, the IGT patch > > > will > > be floated. > > > > Do the igt stuff first. Then you can at least get some CI results for this > > stuff. > > > IGT has be floated. https://patchwork.freedesktop.org/series/107871/ > > Thanks and Regards, > Arun R Murthy > -------------------- -- Ville Syrjälä Intel
