Re: [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects

[Tvrtko Ursulin]

On 08/09/2022 21:07, Nirmoy Das wrote:

i915_gem_drain_workqueue() call i915_gem_drain_freed_objects()
so no need to call that again.

Signed-off-by: Nirmoy Das <nirmoy....@intel.com>
---
  drivers/gpu/drm/i915/i915_gem.c                  | 2 --
  drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 -
  2 files changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index e8a053eaaa89..e16718d79533 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1217,8 +1217,6 @@ void i915_gem_driver_remove(struct drm_i915_private 
*dev_priv)

/* Flush any outstanding unpin_work. */

        i915_gem_drain_workqueue(dev_priv);
-
-       i915_gem_drain_freed_objects(dev_priv);
  }

void i915_gem_driver_release(struct drm_i915_private *dev_priv)

diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c 
b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index f5904e659ef2..5d02346c43a2 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -67,7 +67,6 @@ static void mock_device_release(struct drm_device *dev)
        intel_gt_driver_remove(to_gt(i915));

i915_gem_drain_workqueue(i915);

-       i915_gem_drain_freed_objects(i915);

mock_fini_ggtt(to_gt(i915)->ggtt);

        destroy_workqueue(i915->wq);

Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com>

Regards,

Tvrtko