No functional change. Introduce dg2_cdclk_squash_program and
move squash_ctl register programming bits to this.

v2: s/dg2_cdclk_squash_programming/dg2_cdclk_squash_program (Jani)

Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Balasubramani Vivekanandan <balasubramani.vivekanan...@intel.com>
Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.sriva...@intel.com>
Reviewed-by: Balasubramani Vivekanandan <balasubramani.vivekanan...@intel.com>
---
 drivers/gpu/drm/i915/display/intel_cdclk.c | 23 +++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c 
b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 3893779e0c23..e21cd0fbe29a 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -1705,6 +1705,18 @@ static void bxt_cdclk_pll_update(struct drm_i915_private 
*i915, int vco)
 
 }
 
+static void dg2_cdclk_squash_program(struct drm_i915_private *i915,
+                                        u16 waveform)
+{
+       u32 squash_ctl = 0;
+
+       if (waveform)
+               squash_ctl = CDCLK_SQUASH_ENABLE |
+                            CDCLK_SQUASH_WINDOW_SIZE(0xf) | waveform;
+
+       intel_de_write(i915, CDCLK_SQUASH_CTL, squash_ctl);
+}
+
 static void bxt_set_cdclk(struct drm_i915_private *dev_priv,
                          const struct intel_cdclk_config *cdclk_config,
                          enum pipe pipe)
@@ -1752,15 +1764,8 @@ static void bxt_set_cdclk(struct drm_i915_private 
*dev_priv,
        else
                clock = cdclk;
 
-       if (HAS_CDCLK_SQUASH(dev_priv)) {
-               u32 squash_ctl = 0;
-
-               if (waveform)
-                       squash_ctl = CDCLK_SQUASH_ENABLE |
-                               CDCLK_SQUASH_WINDOW_SIZE(0xf) | waveform;
-
-               intel_de_write(dev_priv, CDCLK_SQUASH_CTL, squash_ctl);
-       }
+       if (HAS_CDCLK_SQUASH(dev_priv))
+               dg2_cdclk_squash_program(dev_priv, waveform);
 
        val = bxt_cdclk_cd2x_div_sel(dev_priv, clock, vco) |
                bxt_cdclk_cd2x_pipe(dev_priv, pipe) |
-- 
2.25.1

Reply via email to