Den 17.11.2022 10.28, skrev Maxime Ripard: > Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and > 625-lines modes in their drivers. > > Since those modes are fairly standard, and that we'll need to use them > in more places in the future, it makes sense to move their definition > into the core framework. > > However, analog display usually have fairly loose timings requirements, > the only discrete parameters being the total number of lines and pixel > clock frequency. Thus, we created a function that will create a display > mode from the standard, the pixel frequency and the active area. > > Tested-by: Mateusz Kwiatkowski <kfyatek+public...@gmail.com> > Signed-off-by: Maxime Ripard <max...@cerno.tech> > > --- I'm no domain expert so apart from the timing details which I can't comment on, it looks fine. I personally advocated for a much simpler solution for these NTSC and PAL modes, but AIUI this is part of a grander plan to support devices with other timings. Acked-by: Noralf Trønnes <nor...@tronnes.org>
- [Intel-gfx] [PATCH v10 00/19] drm: Analog TV Improve... Maxime Ripard
- [Intel-gfx] [PATCH v10 01/19] drm/tests: client... Maxime Ripard
- Re: [Intel-gfx] [PATCH v10 01/19] drm/tests... Noralf Trønnes
- [Intel-gfx] [PATCH v10 02/19] drm/connector: Re... Maxime Ripard
- [Intel-gfx] [PATCH v10 04/19] drm/connector: Re... Maxime Ripard
- [Intel-gfx] [PATCH v10 05/19] drm/connector: Ad... Maxime Ripard
- Re: [Intel-gfx] [PATCH v10 05/19] drm/conne... Mauro Carvalho Chehab
- Re: [Intel-gfx] [PATCH v10 05/19] drm/c... Maxime Ripard
- Re: [Intel-gfx] [PATCH v10 05/19] drm/conne... Noralf Trønnes
- [Intel-gfx] [PATCH v10 06/19] drm/modes: Add a ... Maxime Ripard
- Re: [Intel-gfx] [PATCH v10 06/19] drm/modes... Noralf Trønnes
- [Intel-gfx] [PATCH v10 08/19] drm/modes: Introd... Maxime Ripard
- [Intel-gfx] [PATCH v10 03/19] drm/connector: On... Maxime Ripard
- [Intel-gfx] [PATCH v10 07/19] drm/connector: Ad... Maxime Ripard
- [Intel-gfx] [PATCH v10 10/19] drm/client: Remov... Maxime Ripard
- [Intel-gfx] [PATCH v10 11/19] drm/modes: Introd... Maxime Ripard
- [Intel-gfx] [PATCH v10 12/19] drm/probe-helper:... Maxime Ripard
- [Intel-gfx] [PATCH v10 16/19] drm/vc4: vec: Che... Maxime Ripard
- [Intel-gfx] [PATCH v10 09/19] drm/modes: Proper... Maxime Ripard
- [Intel-gfx] [PATCH v10 13/19] drm/atomic-helper... Maxime Ripard
- [Intel-gfx] [PATCH v10 15/19] drm/vc4: vec: Use... Maxime Ripard