Hi Chris, If I understand correctly we are using GEN6_RP_INTERRUPT_LIMITS to Make sure we continue to get interrupts until we hit the minimum or maximum frequencies for gen6 right? Also, we do setup the gen6_set_rps_thresholds based on the power in gen6_set_rps right?
Instead of adding it in set_rps_thresholds, would it be better to add the Disable/Enable PM Intrrupts based on the current freq in valleyview_set_rps? Let me know if my understanding is right. Thanks Deepak -----Original Message----- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Tuesday, December 17, 2013 8:46 PM To: S, Deepak Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Disable/Enable PM Intrrupts based on the current freq. On Tue, Dec 17, 2013 at 08:35:40PM +0530, deepa...@intel.com wrote: > From: Deepak S <deepa...@intel.com> > > When current delay is already at max delay, Let's disable the PM UP > THRESHOLD INTRRUPTS, so that we will not get further interrupts until > current delay is less than max delay, Also request for the PM DOWN > THRESHOLD INTRRUPTS to indicate the decrease in clock freq. and > viceversa for PM DOWN THRESHOLD INTRRUPTS. > > v2: Use bool variables (Daniel) > > Signed-off-by: Deepak S <deepa...@intel.com> Nak. Why not do this with the rest of the threshold interrupt adjusting code? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
