Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()

[Das, Nirmoy]

pushed to drm-intel-next with a minor fix (s/References:/Closes:)

On 5/22/2023 2:42 PM, Nirmoy Das wrote:

i915_active_fini() finalizes the debug object, which can occur before
the active retires and deactivates the debug object. Wait for one
final time before calling i915_active_fini();

References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311
Signed-off-by: Nirmoy Das <nirmoy....@intel.com>
---
  drivers/gpu/drm/i915/i915_vma.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 20a44788999e..bad698bece27 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -1710,6 +1710,8 @@ static void release_references(struct i915_vma *vma, 
struct intel_gt *gt,
        if (vm_ddestroy)
                i915_vm_resv_put(vma->vm);

+ /* Wait for async active retire */

+       i915_active_wait(&vma->active);
        i915_active_fini(&vma->active);
        GEM_WARN_ON(vma->resource);
        i915_vma_free(vma);