> -----Original Message----- > From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Jani > Nikula > Sent: Monday, June 19, 2023 1:46 AM > To: Bhadane, Dnyaneshwar <dnyaneshwar.bhad...@intel.com>; intel- > g...@lists.freedesktop.org > Cc: Bhadane, Dnyaneshwar <dnyaneshwar.bhad...@intel.com> > Subject: Re: [Intel-gfx] [PATCH 04/11] drm/i915/JSL: s/JSL/JASPERLAKE for > platform/subplatform defines > > On Thu, 15 Jun 2023, Dnyaneshwar Bhadane > <dnyaneshwar.bhad...@intel.com> wrote: > > Follow consistent naming convention. Replace JSL with JASPERLAKE. > > > > Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhad...@intel.com> > > > -#define IS_JSL_EHL(i915) (IS_PLATFORM(i915, INTEL_JASPERLAKE) || \ > > +#define IS_JASPERLAKE_EHL(i915) (IS_PLATFORM(i915, > INTEL_JASPERLAKE) || \ > > IS_PLATFORM(i915, INTEL_ELKHARTLAKE)) > > The new name for this is just dumb. This matches two platforms, JSL and EHL, > and there's no point in one of them being an acronym and the other one not. > > And IS_JASPERLAKE_ELKHARTLAKE() would be too long. > Agreed on the long name. Given that we are not touching Elkhartlake in this series, we can probably skip jasperlake too? Anusha > BR, > Jani. > > -- > Jani Nikula, Intel Open Source Graphics Center
- [Intel-gfx] [PATCH 01/11] drm/i915/TGL: s/TGL/TIGERLAK... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 03/11] drm/i915/TGL: s/RKL/ROCKETLA... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 07/11] drm/i915/adlp: s/ADLP/ALDERL... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 02/11] drm/i915/MTL: s/MTL/METEORLA... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 06/11] drm/i915/SKL: s/SKL/SKYLAKE ... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 09/11] drm/i915/adln: s/ADLP/ALDERL... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 11/11] drm/i915/rplu: s/ADLP/ALDERL... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 05/11] drm/i915/KBL: s/KBL/KABYLAKE... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 04/11] drm/i915/JSL: s/JSL/JASPERLA... Dnyaneshwar Bhadane
- Re: [Intel-gfx] [PATCH 04/11] drm/i915/JSL: s/JSL... Jani Nikula
- Re: [Intel-gfx] [PATCH 04/11] drm/i915/JSL: s... Srivatsa, Anusha
- [Intel-gfx] [PATCH 08/11] drm/i915/rplp: s/ADLP/ALDERL... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 10/11] drm/i915/adls: s/ADLS/ALDERL... Dnyaneshwar Bhadane
- Re: [Intel-gfx] [PATCH 10/11] drm/i915/adls: s/AD... Srivatsa, Anusha
- [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Replace ac... Patchwork
- [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Replace acrony... Patchwork
- [Intel-gfx] ✓ Fi.CI.BAT: success for Replace acronym w... Patchwork
- [Intel-gfx] ✓ Fi.CI.IGT: success for Replace acronym w... Patchwork
- [Intel-gfx] [PATCH 00/11] Replace acronym with full pl... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 01/11] drm/i915/skl: s/SKL/SKY... Dnyaneshwar Bhadane
- [Intel-gfx] [PATCH 04/11] drm/i915/jsl: s/JSL/JAS... Dnyaneshwar Bhadane