On Thu, Aug 10, 2023 at 01:36:20PM -0700, Jonathan Cavitt wrote: > Align igt_spinner_create_request with the hang_create_request > implementation in selftest_hangcheck.c.
The change looks fine, but can we refactor so that there's just a single copy of the common code in igt_spinner.c? If more changes are needed for future platforms it would be better if we didn't have to remember to make the changes in multiple places. Matt > > Signed-off-by: Jonathan Cavitt <jonathan.cav...@intel.com> > --- > drivers/gpu/drm/i915/selftests/igt_spinner.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c > b/drivers/gpu/drm/i915/selftests/igt_spinner.c > index 0f064930ef11..8c3e1f20e5a1 100644 > --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c > +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c > @@ -179,6 +179,9 @@ igt_spinner_create_request(struct igt_spinner *spin, > > *batch++ = arbitration_command; > > + memset32(batch, MI_NOOP, 128); > + batch += 128; > + > if (GRAPHICS_VER(rq->i915) >= 8) > *batch++ = MI_BATCH_BUFFER_START | BIT(8) | 1; > else if (IS_HASWELL(rq->i915)) > -- > 2.25.1 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
