On Fri, Feb 16, 2024 at 10:38:41AM -0800, john.c.harri...@intel.com wrote: > From: John Harrison <john.c.harri...@intel.com> > > The above w/a is required for every platform that the i915 driver > supports. It is fixed on the latest platforms but they are only > supported by Xe instead of i915. So just remove the platform check > completely and keep the code simple.
Well, I was going to say that I would prefer a GMD version greater-than check to be future proof. However if this code gets used in some other new platform a new specific guc support would likely need to be added as well right? Perhaps at least adding a comment in the code? with that Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> > > Signed-off-by: John Harrison <john.c.harri...@intel.com> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c > b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > index 2b450c43bbd7f..a3662edb42032 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > @@ -321,8 +321,7 @@ static u32 guc_ctl_wa_flags(struct intel_guc *guc) > > /* Wa_14018913170 */ > if (GUC_FIRMWARE_VER(guc) >= MAKE_GUC_VER(70, 7, 0)) { > - if (IS_DG2(gt->i915) || IS_METEORLAKE(gt->i915) || > IS_PONTEVECCHIO(gt->i915)) > - flags |= GUC_WA_ENABLE_TSC_CHECK_ON_RC6; > + flags |= GUC_WA_ENABLE_TSC_CHECK_ON_RC6; > } > > return flags; > -- > 2.43.0 >