On Fri, Feb 28, 2014 at 04:42:13PM +0000, Damien Lespiau wrote: > I recently fumbled a patch because I wrote twice num_sprites[i], and it > was the right thing to do in only 50% of the cases. > > This patch ensures I need to write num_sprites[pipe], ie it should be > self-documented that it's per-pipe number of sprites without having to > look at what is 'i' this time around. > > It's all a lame excuse, but it does make it harder to redo the same > mistake. > > Signed-off-by: Damien Lespiau <damien.lesp...@intel.com>
I'd review patches to change all for_each_pipe(i) to for_each_pipe(pipe). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
