On Sat, Mar 08, 2014 at 11:59:42AM -0800, Ben Widawsky wrote: > On Sat, Mar 08, 2014 at 11:58:16AM -0800, Ben Widawsky wrote: > > I'm not clear if the hardware is still subject to the same prefetching > > issues that made us use a scratch page in the first place. In either > > case, we're using garbage with the current code (we will end up using > > offset 0). > > > > This may be the cause of our current gem_cpu_reloc regression with > > PPGTT. I cannot test it at the moment. > > > > Wait NVM... that wasn't gen8. I can't associate this one with a bug.
Yeah, this doesn't appear to achieve anything. ppgtt->base.scratch is only used by ppgtt->base.clear_range() and there is no caller between i915_gem_init_ppgtt() and ppgtt->base.scratch initialisation in gen6_ppgtt_init(). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
