Hi Nitin,

...

> diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c 
> b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
> index 32f3b52a183a..d56410863f26 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
> @@ -230,8 +230,13 @@ static int xcs_resume(struct intel_engine_cs *engine)
>  
>       set_pp_dir(engine);
>  
> -     /* First wake the ring up to an empty/idle ring */
> -     for ((kt) = ktime_get() + (2 * NSEC_PER_MSEC);
> +     /*
> +      * First wake the ring up to an empty/idle ring.
> +      * Use 50ms of delay to let the engine write successfully
> +      * for all platforms. Experimented with different values and

I'm going to change /Experimented/Experiments/

Reviewed-by: Andi Shyti <[email protected]>

Thanks,
Andi

> +      * determined that 50ms works best based on testing.
> +      */
> +     for ((kt) = ktime_get() + (50 * NSEC_PER_MSEC);
>                       ktime_before(ktime_get(), (kt)); cpu_relax()) {
>               /*
>                * In case of resets fails because engine resumes from
> -- 
> 2.25.1

Reply via email to