On 20/12/2024 00:37, Vinay Belgaumkar wrote:
Use the PMU support being added in
https://patchwork.freedesktop.org/series/139121/ to add freq/c6 stats.
Brace yourself for the customary "why". So yes, why?
Gputop so far was a reference showcase for DRM fdinfo, nothing more. Why
add a _subset_ of PMU stats to it? Any other drivers could be wired up?
How far do people intend to grow it, considering alternatives with nicer
UI and more featureful exist?
Or in case the conclusion ends up being "yes", then lets at least share
some more code between intel_gpu_top and this work. Ie. make it in a way
gputop completely subsumes and replaces intel_gpu_top might be an idea.
Regards,
Tvrtko
Cc: Rodrigo Vivi <[email protected]>
Cc: Lucas De Marchi <[email protected]>
Cc: Kamil Konieczny <[email protected]>
Signed-off-by: Vinay Belgaumkar <[email protected]>
Vinay Belgaumkar (4):
tools/gputop: Define data structs for PMU stats
lib/igt_drm_clients: Add pdev and driver info
lib/igt_perf: Add utils to extract PMU event info
tools/gputop: Add GT freq and c6 stats
lib/igt_drm_clients.c | 6 ++
lib/igt_drm_clients.h | 4 +
lib/igt_perf.c | 68 +++++++++++++
lib/igt_perf.h | 2 +
tools/gputop.c | 225 ++++++++++++++++++++++++++++++++++++++++++
tools/meson.build | 2 +-
6 files changed, 306 insertions(+), 1 deletion(-)
