On Tue, 2014-03-25 at 14:49 +0000, Damien Lespiau wrote: > Those fields are supposed to be a good default value for the cursor > size, intended for the case where the hardware doesn't support 64x64 > cursors, for use with a hw agnostic DDX driver for instance. > > We're fine with 64x64 cursors though and don't need to set those fields > (DRM core will return 64 is we don't). If we declare 256x256, that > generic driver will use a big buffer for the cursor, without any good > reason. > > Cc: Sagar Kamble <sagar.a.kam...@intel.com> > Cc: Imre Deak <imre.d...@intel.com> > Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 80dd1c2..7a47657 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -10557,8 +10557,6 @@ static void intel_crtc_init(struct drm_device *dev, > int pipe) > intel_crtc->max_cursor_width = CURSOR_WIDTH; > intel_crtc->max_cursor_height = CURSOR_HEIGHT; > } > - dev->mode_config.cursor_width = intel_crtc->max_cursor_width; > - dev->mode_config.cursor_height = intel_crtc->max_cursor_height;
I thought drm_getcap should return the max cursor size, using these two
fields.
--Imre
>
> drm_mode_crtc_set_gamma_size(&intel_crtc->base, 256);
> for (i = 0; i < 256; i++) {
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
