On Tue, 2025-04-08 at 07:57 +0000, Manna, Animesh wrote: > > > > -----Original Message----- > > From: Hogander, Jouni <[email protected]> > > Sent: Tuesday, April 8, 2025 1:20 PM > > To: [email protected]; Manna, Animesh > > <[email protected]>; [email protected] > > Cc: Nikula, Jani <[email protected]>; B, Jeevan > > <[email protected]> > > Subject: Re: [PATCH v7 2/8] drm/i915/lobf: Add debug print for LOBF > > > > On Thu, 2025-04-03 at 14:58 +0530, Animesh Manna wrote: > > > Lobf is enabled part of ALPM configuration and if has_lobf is set > > > to > > > true respective bit for LOBF will be set. Add debug print while > > > setting the bitfield of LOBF. > > > > I think you should add also debug print about disabling LOBF. How > > about two > > more printouts alpm enable and alpm disable? > > LOBF disable and ALPM disable print is added in patch 4 and patch 8 > respectively. > Will add ALPM enable print.
Yes noticed that. This should be ok. You can ignore my comment here. BR, Jouni Högander > > Regards, > Animesh > > > > BR, > > > > Jouni Högander > > > > > > > > Signed-off-by: Animesh Manna <[email protected]> > > > Reviewed-by: Jouni Högander <[email protected]> > > > --- > > > drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > > > b/drivers/gpu/drm/i915/display/intel_alpm.c > > > index 354510bb437d..5293cbd02988 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > > > @@ -353,8 +353,10 @@ static void lnl_alpm_configure(struct > > > intel_dp > > > *intel_dp, > > > ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_d > > > p- > > > > alpm_parameters.fast_wake_lines); > > > } > > > > > > - if (crtc_state->has_lobf) > > > + if (crtc_state->has_lobf) { > > > alpm_ctl |= ALPM_CTL_LOBF_ENABLE; > > > + drm_dbg_kms(display->drm, "Link off between > > > frames > > > (LOBF) enabled\n"); > > > + } > > > > > > alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp- > > > > alpm_parameters.check_entry_lines); > > > >
