On 02/09/2025 19:51, Jani Nikula wrote:
Split out intel_panic functionality separate from intel_bo abstraction,
and lift the framebuffer allocation back to where it belongs in
intel_fb.c.
There's more that should be improved, ideally making struct
intel_framebuffer opaque towards i915 and xe, but this already goes
along way in adjusting where the abstractions should happen.
Thanks for this series, this makes sense, and moving the panic part to
intel_panic.c is a good idea.
I think this may conflict with
https://patchwork.freedesktop.org/series/150887/ but that should be
trivial to resolve.
For the whole series:
Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>
Best regards,
--
Jocelyn
BR,
Jani.
Cc: Jocelyn Falempe <jfale...@redhat.com>
Cc: Maarten Lankhorst <d...@lankhorst.se>
Jani Nikula (8):
drm/i915/fb: add intel_framebuffer_alloc()
drm/{i915,xe}/panic: split out intel_panic.[ch]
drm/{i915,xe}/panic: rename intel_bo_panic_*() to intel_panic_*()
drm/{i915,xe}/fb: add panic pointer member to struct intel_framebuffer
drm/{i915,xe}/panic: rename struct {i915,xe}_panic_data to struct
intel_panic
drm/{i915,xe}/panic: move framebuffer allocation where it belongs
drm/{i915,xe}/panic: convert intel_panic_finish() to struct
intel_panic
drm/{i915,xe}/panic: pass struct intel_panic to intel_panic_setup()
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/i9xx_plane.c | 4 +-
drivers/gpu/drm/i915/display/intel_bo.c | 15 ---
drivers/gpu/drm/i915/display/intel_bo.h | 3 -
.../drm/i915/display/intel_display_types.h | 2 +
drivers/gpu/drm/i915/display/intel_fb.c | 23 ++++-
drivers/gpu/drm/i915/display/intel_fb.h | 3 +
drivers/gpu/drm/i915/display/intel_panic.c | 27 ++++++
drivers/gpu/drm/i915/display/intel_panic.h | 14 +++
drivers/gpu/drm/i915/display/intel_plane.c | 6 +-
.../drm/i915/display/skl_universal_plane.c | 3 +-
drivers/gpu/drm/i915/gem/i915_gem_object.h | 11 ++-
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 40 +++-----
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/display/intel_bo.c | 91 -------------------
drivers/gpu/drm/xe/display/xe_panic.c | 80 ++++++++++++++++
16 files changed, 176 insertions(+), 148 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_panic.c
create mode 100644 drivers/gpu/drm/i915/display/intel_panic.h
create mode 100644 drivers/gpu/drm/xe/display/xe_panic.c
