On Mon, 2025-09-08 at 10:35 +0300, Luca Coelho wrote: > This FIXME has been there forever and apparently the _proper code_ has > never been added, and, since it's a very old platform alreday, most > likely never will. It hasn't been a problem to keep the workaround > for all cases, so let's drop the FIXME tag. > > Signed-off-by: Luca Coelho <[email protected]> > --- > drivers/gpu/drm/i915/display/skl_watermark.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
Reviewed-by: Vinod Govindapillai <[email protected]> > diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c > b/drivers/gpu/drm/i915/display/skl_watermark.c > index 3b409442db37..0ce3420a919e 100644 > --- a/drivers/gpu/drm/i915/display/skl_watermark.c > +++ b/drivers/gpu/drm/i915/display/skl_watermark.c > @@ -83,8 +83,8 @@ u8 intel_enabled_dbuf_slices_mask(struct intel_display > *display) > } > > /* > - * FIXME: We still don't have the proper code detect if we need to apply the > WA, > - * so assume we'll always need it in order to avoid underruns. > + * We don't have the proper code detect if we need to apply the WA, so > + * assume we'll always need it in order to avoid underruns. > */ > static bool skl_needs_memory_bw_wa(struct intel_display *display) > {
