On Tue, 30 Sep 2025 12:30:03 +0200
Boris Brezillon <[email protected]> wrote:

> > +unsigned long drm_gem_get_unmapped_area(struct file *filp, unsigned long 
> > uaddr,
> > +                                   unsigned long len, unsigned long pgoff,
> > +                                   unsigned long flags)
> > +{
> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > +   struct drm_gem_object *obj;
> > +   unsigned long ret;
> > +
> > +   obj = drm_gem_object_lookup_from_offset(filp, pgoff, len >> PAGE_SHIFT);
> > +   if (IS_ERR(obj))  
> 
> Is this supposed to happen? If not, I'd be tempted to add a
> WARN_ON_ONCE().

Taking that back. I think you need it for non-GEM backed mappings, like
userland IOMEM mappings.

> 
> > +           return mm_get_unmapped_area(current->mm, filp, uaddr, len, 0,
> > +                                       flags);
> > +

Reply via email to