Hi Janusz, On 2025-10-15 at 14:39:20 +0200, Janusz Krzysztofik wrote: > Subtests that measure time of resume after engine reset require results > from at least 9 reset-resume cycles for reasonable calculation of a median > value to be compared against a presumed limit. On most Gen12+ platforms, > as well as on some older ones like JSL, CHV, ILK or ELK, the current limit > of 5 seconds for collecting those results occurs too short. > > Raise the limit to an empirically determined value of 20 seconds and break > the loop as soon as 9 results are collected. > > v3: Use NUMER_OF_MEASURED_CYCLES_NEEDED symbol (Kamil). > v2: Split out a change in handling of not enough measurements to a > separate patch (Kamil), > - reword commit message to be more distinct from other patches in > series (Kamil), > - reword commit message and description so they no longer state the > scope of the issue is limited to Gen12+, and list other (non-Gen12+) > platforms found also affected. > > Cc: Krzysztof Karas <[email protected]> > Cc: Kamil Konieczny <[email protected]> > Signed-off-by: Janusz Krzysztofik <[email protected]> > --- > tests/intel/gem_eio.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/intel/gem_eio.c b/tests/intel/gem_eio.c > index 35291e759d..3b7a6bd209 100644 > --- a/tests/intel/gem_eio.c > +++ b/tests/intel/gem_eio.c > @@ -930,7 +930,7 @@ static void reset_stress(int fd, uint64_t ahnd, const > intel_ctx_t *ctx0, > gem_write(fd, obj.handle, 0, &bbe, sizeof(bbe)); > > igt_stats_init(&stats); > - igt_until_timeout(5) { > + igt_until_timeout(20) { > const intel_ctx_t *ctx = context_create_safe(fd); > igt_spin_t *hang; > unsigned int i; > @@ -979,6 +979,9 @@ static void reset_stress(int fd, uint64_t ahnd, const > intel_ctx_t *ctx0, > gem_sync(fd, obj.handle); > igt_spin_free(fd, hang); > intel_ctx_destroy(fd, ctx); > + > + if (stats.n_values >= NUMER_OF_MEASURED_CYCLES_NEEDED) > + break;
Reviewed-by: Kamil Konieczny <[email protected]> > } > check_wait_elapsed(name, fd, &stats); > igt_stats_fini(&stats); > -- > 2.51.0 >
