Hi Jonathan, > Add error handling for the following VFIO_DEVICE_SET_IRQS cases with > respect to the hdr struct: > > - More than one VFIO_IRQ_DATA_TYPE_MASK flag is set in hdr.flags > - More than one VFIO_IRQ_ACTION_TYPE_MASK flag is set in hdr.flags > - hdr.count is not specified > > Note that since hdr.count != 0, data_size != 0 is guaranteed unless > vfio_set_irqs_validate_and_prepare fails and returns an error. So, we > no longer need to check data_size before running memdup_user because > checking the return value of the function is sufficient.
The code looks good and I don't think the BAT failure is related to your change: Reviewed-by: Krzysztof Karas <[email protected]> -- Best Regards, Krzysztof
