On Tue, Sep 23, 2025 at 06:40:42PM +0530, Ankit Nautiyal wrote: > Introduce REG_FIELD_MAX macro as local wrapper around FIELD_MAX() to return > the maximum value representable by a bit mask. The value is cast to u32 > for consistency with other REG_* macros and assumes the bitfield fits > within 32 bits. > > Signed-off-by: Ankit Nautiyal <[email protected]> > --- > drivers/gpu/drm/i915/i915_reg_defs.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_reg_defs.h > b/drivers/gpu/drm/i915/i915_reg_defs.h > index bfe98cb9a038..50967f887790 100644 > --- a/drivers/gpu/drm/i915/i915_reg_defs.h > +++ b/drivers/gpu/drm/i915/i915_reg_defs.h > @@ -174,6 +174,16 @@ > */ > #define REG_FIELD_GET8(__mask, __val) ((u8)FIELD_GET(__mask, __val)) > > +/** > + * REG_FIELD_MAX() - produce the maximum value representable by a field > + * @_mask: shifted mask defining the field's length and position > + * > + * Local wrapper for FIELD_MAX() to return the maximum bit value that can > + * be held in the field specified by @_mask, cast to u32 for consistency > + * with other macros. > + */ > +#define REG_FIELD_MAX(_mask) ((u32)FIELD_MAX(_mask))
We use a double underscore '__mask' everwhere else. Let's try to be consistent. with that Reviewed-by: Ville Syrjälä <[email protected]> > + > typedef struct { > u32 reg; > } i915_reg_t; > -- > 2.45.2 -- Ville Syrjälä Intel
