Quoting Shekhar Chauhan (2025-10-15 05:02:40-03:00) > >On 10/15/2025 8:45, Gustavo Sousa wrote: >> From: Luca Coelho <[email protected]> >> >> Starting from display version 35, we don't need to use method1 to > >In the patch title and this description, can we have something which >explains what exactly is method1 or method2? Seems too vague.
Hm... The referred Bspec has the descriptions of each method. -- Gustavo Sousa > >-shekhar > >> calculate the watermark values anymore, so skip it. >> >> Bspec: 68985 >> Signed-off-by: Luca Coelho <[email protected]> >> Signed-off-by: Gustavo Sousa <[email protected]> >> --- >> drivers/gpu/drm/i915/display/skl_watermark.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c >> b/drivers/gpu/drm/i915/display/skl_watermark.c >> index 88342d07727f..fba7448c4920 100644 >> --- a/drivers/gpu/drm/i915/display/skl_watermark.c >> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c >> @@ -1809,6 +1809,8 @@ static void skl_compute_plane_wm(const struct >> intel_crtc_state *crtc_state, >> >> if (wp->y_tiled) { >> selected_result = max_fixed16(method2, wp->y_tile_minimum); >> + } else if (DISPLAY_VER(display) >= 35) { >> + selected_result = method2; >> } else { >> if ((wp->cpp * crtc_state->hw.pipe_mode.crtc_htotal / >> wp->dbuf_block_size < 1) && >>
