Hi Ville, all, > DMC_EVT_CTL_ENABLE cannot be cleared once set. So currently > any event we never enable will have DMC_EVT_CTL_ENABLE cleared, > whereas any event which has been enabled even once will have > DMC_EVT_CTL_ENABLE set. For that reason assert_dmc_loaded() has > a special case to ignore any mismatches in DMC_EVT_CTL_ENABLE.
> Eliminate the special case by always configuring DMC_EVT_CTL_ENABLE > based on the original firmware event definition. Now all > event handlers will have DMC_EVT_CTL_ENABLE set, whether or > not the event has been enabled in the past. > All disabled event handlers will still have the event type set > to DMC_EVENT_FALSE so they will not actually trigger despite > DMC_EVT_CTL_ENABLE being set. LGTM. Reviewed-by: Petr Vorel <[email protected]> Kind regards, Petr
