Re: [PATCH v2 32/32] drm/i915/nvls: Add NVL-S display support

[Shekhar Chauhan]

On 10/22/2025 5:58, Gustavo Sousa wrote:

From: Sai Teja Pottumuttu <sai.teja.pottumu...@intel.com>

Add platform description and PCI IDs for NVL-S.

BSpec: 74201
Signed-off-by: Sai Teja Pottumuttu <sai.teja.pottumu...@intel.com>
Signed-off-by: Gustavo Sousa <gustavo.so...@intel.com>

LGTM,

Reviewed-by: Shekhar Chauhan <shekhar.chau...@intel.com>

---
  drivers/gpu/drm/i915/display/intel_display_device.c | 5 +++++
  drivers/gpu/drm/i915/display/intel_display_device.h | 4 +++-
  2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c 
b/drivers/gpu/drm/i915/display/intel_display_device.c
index a38de39ed98c..2350ade1419c 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.c
+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
@@ -1420,6 +1420,10 @@ static const struct platform_desc ptl_desc = {
        }
  };

+static const struct platform_desc nvl_desc = {

+       PLATFORM(novalake),
+};
+
  __diag_pop();

/*

@@ -1495,6 +1499,7 @@ static const struct {
        INTEL_BMG_IDS(INTEL_DISPLAY_DEVICE, &bmg_desc),
        INTEL_PTL_IDS(INTEL_DISPLAY_DEVICE, &ptl_desc),
        INTEL_WCL_IDS(INTEL_DISPLAY_DEVICE, &ptl_desc),
+       INTEL_NVLS_IDS(INTEL_DISPLAY_DEVICE, &nvl_desc),
  };

static const struct {

diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h 
b/drivers/gpu/drm/i915/display/intel_display_device.h
index 8fdb8a0a4282..ed03630f9dcc 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.h
+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
@@ -102,7 +102,9 @@ struct pci_dev;
        func(battlemage) \
        /* Display ver 30 (based on GMD ID) */ \
        func(pantherlake) \
-       func(pantherlake_wildcatlake)
+       func(pantherlake_wildcatlake) \
+       /* Display ver 35 (based on GMD ID) */ \
+       func(novalake)

#define __MEMBER(name) unsigned long name:1;